RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-25 Thread Stefan Dösinger
ssage- > From: Nick Burns [mailto:adge...@hotmail.com] > Sent: Thursday, December 25, 2008 1:06 AM > To: ste...@codeweavers.com; wine-devel@winehq.org > Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer > (re-redux) > > > Thanks for the explanation -

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-24 Thread Nick Burns
> From: ste...@codeweavers.com > To: adge...@hotmail.com; wine-devel@winehq.org > Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer > (re-redux) > Date: Wed, 24 Dec 2008 15:48:24 +0100 > >> Thanks for reviewing my patch (it sure makes the SHOGO menu m

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-24 Thread Stefan Dösinger
> Thanks for reviewing my patch (it sure makes the SHOGO menu much nicer) > BTW do you know if I need to resubmit my other SHOGO patch ([PATCH] Fix > ddraw surface version setting)? Yes, I recommend to do that. It is likely that it was lost or didn't apply any longer after the 3 days it waited in m

Re: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-24 Thread Roderick Colenbrander
eavers.com; wine-devel@winehq.org> Subject: RE: [PATCH] Fix > glReadPixels call from read_from_framebuffer (re-redux)> Date: Tue, 23 Dec > 2008 > 11:11:08 -0800> > > Thanks for reviewing my patch (it sure makes the SHOGO > menu much nicer)> BTW do you know if I need to res

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Nick Burns
Concerning negative pixelzoom and drawpixels on R500> Please file a radar on that (and email the mac-opengl mailing list)> > > - Nick> > >> From: ste...@codeweavers.com>> To: wine-devel@winehq.org>> Subject: RE: [PATCH] Fix g

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Nick Burns
list) - Nick > From: ste...@codeweavers.com > To: wine-devel@winehq.org > Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer > (re-redux) > Date: Tue, 23 Dec 2008 13:30:40 +0100 > > This patch looks good. > >

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Stefan Dösinger
This patch looks good. There's one last thing we should check: It seems that this is the only code that uses GL_PACK_ROW_LENGTH and friends, so the backup and restore is probably not needed. I think for now it is better to add it because I suspect the code in surface_download_data most likely depe