Re: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Alexandre Julliard
Joris Huizer <[EMAIL PROTECTED]> writes: > hmm, well, then what more is needed than s/strncpy\(/lstrcpynA/ and > s/strncpyW/lstrcpynW and a note for future code .. ? A careful review of the code to ensure that lstrcpyn semantics are really what we want. In several cases we know that we are copyin

RE: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Francois Gouget
On Thu, 13 Jan 2005, Ge van Geldorp wrote: [...] Couldn't we just make a sane implementation of strncpy, not adding more '\0' characters than necessary and making sure the last character is an '\0'? That sane implementation already exists as lstrcpynA/lstrcpynW in kernel32. Btw, Mike actually wrote

Re: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Mike McCormack
hmm, well, then what more is needed than s/strncpy\(/lstrcpynA/ and s/strncpyW/lstrcpynW and a note for future code .. ? Yes, my bad. I'll resend the suggestion. Mike

Re: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Joris Huizer
Ge van Geldorp wrote: From: Joris Huizer Mike McCormack wrote: ChangeLog: * Add janitorial task to avoid using strncpy Couldn't we just make a sane implementation of strncpy, not adding more '\0' characters than necessary and making sure the last character is an '\0'? That sane implementation alr

RE: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Ge van Geldorp
> From: Joris Huizer > > Mike McCormack wrote: > > ChangeLog: > > * Add janitorial task to avoid using strncpy > > Couldn't we just make a sane implementation of strncpy, not > adding more '\0' characters than necessary and making sure > the last character is an '\0'? That sane implementation a

Re: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Joris Huizer
Mike McCormack wrote: ChangeLog: * Add janitorial task to avoid using strncpy Index: templates/en/janitorial.template === RCS file: /home/wine/lostwages/templates