Re: Question some code in server/request.c

2007-03-06 Thread Paul Vriens
Alexandre Julliard wrote: Kari Hurtta <[EMAIL PROTECTED]> writes: Code assumes that 'dir' is for "/dir1/dir2" 1) Code crashes if there is no '/' on 'dir' at all. and 2) Code does wrong thing if dir is just "/dir2" Neither can happen. The server dir is in format /tmp/.wine-%u/server-%x-%x.

Re: Question some code in server/request.c

2007-03-06 Thread Alexandre Julliard
Kari Hurtta <[EMAIL PROTECTED]> writes: > Code assumes that 'dir' is for "/dir1/dir2" > > 1) Code crashes if there is no '/' on 'dir' at all. > > and > > 2) Code does wrong thing if dir is just "/dir2" Neither can happen. The server dir is in format /tmp/.wine-%u/server-%x-%x. -- Alexandre Jull

Re: Question some code in server/request.c

2007-03-06 Thread Kari Hurtta
"Paul Vriens" <[EMAIL PROTECTED]> writes in gmane.comp.emulators.wine.devel: > Hi, > > while going through the Coverity reports I found CID-293 that mentions > a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. > > If I look at the code (starting at line 537): > > /* create the

Re: Question some code in server/request.c

2007-03-06 Thread Marcus Meissner
On Tue, Mar 06, 2007 at 01:34:45PM +, Robert Shearman wrote: > Paul Vriens wrote: > >Hi, > > > >while going through the Coverity reports I found CID-293 that mentions > >a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. > > > >If I look at the code (starting at line 537): > >

Re: Question some code in server/request.c

2007-03-06 Thread Robert Shearman
Paul Vriens wrote: Hi, while going through the Coverity reports I found CID-293 that mentions a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. If I look at the code (starting at line 537): /* create the server directory and chdir to it */ static void create_server_dir( const

Question some code in server/request.c

2007-03-06 Thread Paul Vriens
Hi, while going through the Coverity reports I found CID-293 that mentions a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. If I look at the code (starting at line 537): /* create the server directory and chdir to it */ static void create_server_dir( const char *dir ) { ch