Re: [PATCH v23] winepulse: add pulseaudio driver

2013-05-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25724 Your paranoid android

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-07-04 Thread Maarten Lankhorst
Hey Joerg, 2012/6/26 : > Hi, > >>If you don't paste all the mmdevapi tests with the fix in my git tree, it's a >>regression. I don't want to see held_Frames because it's a shadow buffer. >>If winmm and dsound don't work without it, they're wrong, fix those. > > I won't comment on the two individu

[PATCH] winepulse.drv: Add PulseAudio driver

2012-06-26 Thread Joerg-Cyril.Hoehle
Hi, >If you don't paste all the mmdevapi tests with the fix in my git tree, it's a >regression. I don't want to see held_Frames because it's a shadow buffer. >If winmm and dsound don't work without it, they're wrong, fix those. I won't comment on the two individual pulseaudio drivers. Unfortunate

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Darryl Slack
Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I was

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Chris Robinson
On Monday, June 18, 2012 11:18:45 AM Andrew Eikum wrote: > Is there any guarantee that Pulse /will/ give us a sufficient buffer? > From the API docs[1], it just "tries to assure" that we have the > requested buffer size, which actually means nothing. It "tries to assure that at least tlength bytes

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Mon, Jun 18, 2012 at 08:49:55AM -0700, Chris Robinson wrote: > On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: > > Yeah, I experimented with ADJUST_LATENCY, as it seems to be the trick > > to getting lower latencies. Then we have to maintain our own buffer, > > which is why I switched to

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Chris Robinson
On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: > We chatted a little on IRC this weekend, but thanks again for the > advice. No problem. :) > Mmdevapi sends it data to the lower systems in period-sized chunks, > and the reported buffer fill level decreases in period-sized chunks. > But t

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Fri, Jun 15, 2012 at 06:23:57PM -0700, Chris Robinson wrote: > The update_size is only relevant if mmdevapi updates in period-sized chunks. > If it doesn't, you can just remove it and the rounding. The tlength should be > kept updated using pa_stream_set_buffer_attr_callback, in case the serve

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-16 Thread Maarten Lankhorst
What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix i

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-15 Thread Chris Robinson
On Friday, June 15, 2012 3:39:33 PM Andrew Eikum wrote: > One thing to note is that PulseAudio has an absurdly high default > latency (two seconds), and due to its poor API there's no (easy) way > for us to control it. The latency is likely caused by PulseAudio setting a much larger tlength (and

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-15 Thread Andrew Eikum
On Thu, Jun 14, 2012 at 02:46:37PM -0500, Rosanne DiMesio wrote: > A forum user reported this behavior with the Ubuntu 12.04 wine1.5 packages, > which are apparently only available with the winepulse patch. > > http://forum.winehq.org/viewtopic.php?t=15747 > Thanks. I was able to reproduce it

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Rosanne DiMesio
On Thu, 14 Jun 2012 13:00:33 -0500 Andrew Eikum wrote: > On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote: > > > > It doesn't work here, it's apparently using the driver even though > > PulseAudio is not running on this box: > > > > I've tried this on two operating systems, o

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Alexandre Julliard
Andrew Eikum writes: > Also, I should change this to load libpulse at runtime instead of > compile time, right? It works fine as-is, except it prints a > load_builtin_dll err. I'll do that for the next version of the patch. Failing to load when libpulse is missing is fine, there's no need to loa

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-14 Thread Andrew Eikum
On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote: > Andrew Eikum writes: > > > The configure.ac changes and parts of the driver itself were written by > > Maarten Lankhorst. > > It doesn't work here, it's apparently using the driver even though > PulseAudio is not running on th

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver

2012-06-13 Thread Alexandre Julliard
Andrew Eikum writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstrea

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-11 Thread Alexandre Julliard
Andrew Eikum writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTIO

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-10 Thread Dmitry Timoshkov
Andrew Eikum wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c |4 +- > dlls/winepulse.drv/Makefile.in|9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 > + > dlls/winepulse.drv/winepulse.drv.spec

Re: [RESEND] [PATCH] winepulse: Add pulseaudio driver, v9

2012-03-07 Thread Stefan Dösinger
Hi Maarten, >From a technical point of view, two things popped out: 1) configure is autogenerated by Alexandre, so you shouldn't include it in your patch. configure.ac is enough. 2) The patch doesn't apply with git-am. I don't know how much of an issue this is for AJ, but I prefer git-am over gi

Re: Wine PulseAudio Driver

2008-10-21 Thread Arthur Taylor
> Where are the patches? Should they have been attached here? Sorry, I guess I should have specified. The patches are in the bugzilla entry http://bugs.winehq.org/show_bug.cgi?id=10495 . The patches are too big for attaching. -- Arthur Taylor <[EMAIL PROTECTED]>

Re: Wine PulseAudio Driver

2008-10-20 Thread Arthur Taylor
Hello. I have updated the testing pulseaudio waveout patch for http://bugs.winehq.org/show_bug.cgi?id=10495 The patch has been split in two. The first adds a stub driver that just creates waveout devices based upon pulseaudio sinks and adds checks for pulseaudio to configure.ac. The second patch ad

Re: Wine PulseAudio Driver

2008-10-06 Thread Arthur Taylor
Umm, disregard all of this... sorry for spam > To wine developers: would it be useful to review dlls/winmm? Currently > all mm-drivers (aux, mid, mod, wid, wod) functions are called using > MDRV_Message calls. The arguments of a MDRV_Message are the device id > (an array index), the message identif

Re: Wine PulseAudio Driver

2008-10-02 Thread Juan Lang
> Humm, I can see splitting the changes to configure.ac and Makefile.in, > but as for splitting the rest of it, should I split it per-file? No. Patches should be split along functional lines. E.g., patch 1: add stub driver patch 2: add small feature x to driver patch 3: add small feature y to dr

Re: Wine PulseAudio Driver

2008-10-02 Thread Arthur Taylor
> Hi Art, > > > Currently I am looking for any feedback at all. > > I believe you've already gotten some: split up your patches so that > we can read them a little more easily. If you send a large patch as a > new contributor, it's very unlikely to get committed. Humm, I can see splitting the

Re: Wine PulseAudio Driver

2008-10-02 Thread Juan Lang
Hi Art, > Currently I am looking for any feedback at all. I believe you've already gotten some: split up your patches so that we can read them a little more easily. If you send a large patch as a new contributor, it's very unlikely to get committed. Also, this function: +/* +const char * PULSE

Re: Wine PulseAudio Driver

2008-10-02 Thread Arthur Taylor
I have put a newer patch in bugzilla: http://bugs.winehq.org/attachment.cgi?id=16412&action=edit Currently I am looking for any feedback at all. Should I send a message to wine-patches as well? > 2. We ought to be able to use PulseAudio's ALSA emulation. If that > doesn't work, then either our A

Re: Wine PulseAudio Driver

2008-10-01 Thread Scott Ritchie
Reece Dunn wrote: > 2008/9/29 Scott Ritchie <[EMAIL PROTECTED]>: >> Arthur Taylor wrote: >>> Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have >>> since noticed that it uses parts of the api from 0.9.11 and compilation >>> will fail against previous versions. >>> >>> Thanks >> As

Re: Wine PulseAudio Driver

2008-09-29 Thread Reece Dunn
2008/9/29 Scott Ritchie <[EMAIL PROTECTED]>: > Arthur Taylor wrote: >> Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have >> since noticed that it uses parts of the api from 0.9.11 and compilation >> will fail against previous versions. >> >> Thanks > > As an aside, 0.9.11 is newe

Re: Wine PulseAudio Driver

2008-09-29 Thread Scott Ritchie
Arthur Taylor wrote: > Also, in the patch, configure checks for pulseaudio >= 0.9.7. I have > since noticed that it uses parts of the api from 0.9.11 and compilation > will fail against previous versions. > > Thanks As an aside, 0.9.11 is newer than most users have (Ubuntu 8.04 has 0.9.10, for in

Re: Wine PulseAudio Driver

2008-09-28 Thread Maarten Lankhorst
Hi Arthur, 2008/9/27, Arthur Taylor <[EMAIL PROTECTED]>: > "If someone wants to write a pulseaudio driver, he should feel free to > do so, but he should be aware that just writing a simple 20 line > linear PCM out driver is not sufficient." > http://bugs.winehq.org

Re: Wine PulseAudio Driver

2008-09-27 Thread Juan Lang
>> Great. In general, emailing the patch here will get more feedback >> than posting it to bugzilla. > > Woots! Um.. I still don't see the patch? Sorry, but I'm too lazy to get it myself. Could you send it here? Also, just to warn you: some people disagree that a

Re: Wine PulseAudio Driver

2008-09-27 Thread Arthur Taylor
On Sat, 2008-09-27 at 11:37 -0700, Juan Lang wrote: > Hi Arthur, > > > I have written a waveout/in driver for wine to use pulseaudio which is > > in bugzilla. I would appreciate feedback on it, as I have received > > little thus far. > > Great. In general, emailing the patch here will get more f

Re: Wine PulseAudio Driver

2008-09-27 Thread Juan Lang
Hi Arthur, > I have written a waveout/in driver for wine to use pulseaudio which is > in bugzilla. I would appreciate feedback on it, as I have received > little thus far. Great. In general, emailing the patch here will get more feedback than posting it to bugzilla. > I would appreciate it also

Wine PulseAudio Driver

2008-09-27 Thread Arthur Taylor
"If someone wants to write a pulseaudio driver, he should feel free to do so, but he should be aware that just writing a simple 20 line linear PCM out driver is not sufficient." http://bugs.winehq.org/show_bug.cgi?id=10495 I have written a waveout/in driver for wine to use pulseaudio w

Re: PulseAudio driver

2007-07-18 Thread Joe Baker
Stéphan Kochen wrote the following on 04/02/2007 06:11 AM: > Hello everyone, > > I've been working on a PulseAudio driver for Wine for a couple of days > now. It was suggested I should drop a note on to wine-devel, so here I > am. :) I also cc'd pulseaudio-discuss. (And su

PulseAudio driver

2007-04-02 Thread Stéphan Kochen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello everyone, I've been working on a PulseAudio driver for Wine for a couple of days now. It was suggested I should drop a note on to wine-devel, so here I am. :) I also cc'd pulseaudio-discuss. (And subscribed to both.) I pers