Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Vitaly Lipatov
В сообщении от 12 апреля 2006 15:17 Mike McCormack написал(a): > Vitaly Lipatov wrote: > > В сообщении от 12 апреля 2006 14:18 Alexandre Julliard написал(a): > >>IsBadReadPtr is broken and should never be used. You need to add an > >>exception handler around the actual access. > > > > I know many M

RE: Protect some DIB functions from bad inputs.

2006-04-12 Thread Rolf Kalbermatter
Mike Hearn [mailto:[EMAIL PROTECTED] wrote: > IsBad*Ptr has historically been used throughout Win32 to verify arguments, > but this was never a good idea and in Vista it has been "banned", which I > guess means Microsoft have gone through and removed the tests. Or at least > are not using them any

Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Mike McCormack
Vitaly Lipatov wrote: В сообщении от 12 апреля 2006 14:18 Alexandre Julliard написал(a): IsBadReadPtr is broken and should never be used. You need to add an exception handler around the actual access. I know many MS's dlls use IsBadReadPtr for check pointers. IsBadReadPtr is malfunction conc

Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Mike Hearn
On Wed, 12 Apr 2006 14:44:18 +0400, Vitaly Lipatov wrote: > I know many MS's dlls use IsBadReadPtr for check pointers. > IsBadReadPtr is malfunction conceptually or it is not realized correctly yet? The problem is you can't use it in thread safe code, because the pointer may be correct when you te

Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Vitaly Lipatov
В сообщении от 12 апреля 2006 14:18 Alexandre Julliard написал(a): > IsBadReadPtr is broken and should never be used. You need to add an > exception handler around the actual access. I know many MS's dlls use IsBadReadPtr for check pointers. IsBadReadPtr is malfunction conceptually or it is not rea

Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > I have no idea why it was not merged, never got any comments. Cc' ed to > the developers list for suggestions. A re-diffed patch is attached. IsBadReadPtr is broken and should never be used. You need to add an exception handler around the actual access.

Re: Protect some DIB functions from bad inputs.

2006-04-12 Thread Rein Klazes
On Tue, 11 Apr 2006 10:24:14 +0200, you wrote: >> Hi, >> >> There are a couple of entries in the bug database (at least #4334 and >> #4664) where the application calculates a wrong pointer for bitmap data. >> The application survives on Windows but crashes on wine. >> >> >> Changelog: >> dlls/x