Re: Printing bugfixes

2004-01-02 Thread Dmitry Timoshkov
"Mike Hearn" <[EMAIL PROTECTED]> wrote: > +num = sizeof(PrinterName); > +if (!GetDefaultPrinterW(PrinterName, &num)) > + WCHAR default_name[255]; > + DWORD default_name_size = sizeof(default_name); > + > + if (GetDefaultPrinterW(default_name, &default_name_size) == 0) { You should pass t

Re: Printing bugfixes

2004-01-02 Thread Huw D M Davies
On Fri, Jan 02, 2004 at 02:47:04PM +, Mike Hearn wrote: > Or that this line: > sprintf(buf,"%s,WINEPS,LPR:%s",name,devname); > should be > sprintf(buf,"%s,WINEPS,%s",devname,devname); Yes like that, but you'll then have to add the LPR: bit to devname for the printcap and CUPS cases before th

Re: Printing bugfixes

2004-01-02 Thread Mike Hearn
On Fri, 2004-01-02 at 12:35, Huw D M Davies wrote: > Actually I don't see why we need a different name and devname we > should just use devname for both entries instead. I think it's a > hangover from some old code OK. I'll resend just using devname. > Your patch however looks wrong, you're addin

Re: Printing bugfixes

2004-01-02 Thread Huw D M Davies
On Thu, Jan 01, 2004 at 08:23:20PM +, Mike Hearn wrote: > ChangeLog: > - Write out default printer name in the order used by WinME > - Support PRINTER_ENUM_DEFAULT > - Add FIXME for enumerating print providers > > I'd appreciate somebody with a CUPs and lpr setup ensuring the order > change do