"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> Just one random example out of the committed Winefile patch:
>
> - int idx = ListBox_AddString(hlbox, infoStr);
> - ListBox_SetItemData(hlbox, idx, pTxt);
> + int idx = SendMessage(hlbox, LB_ADDSTRING, 0L, (LPARAM)infoStr);
> + SendMessage(hlbox, LB_SET
2006/3/19, Alexandre Julliard <[EMAIL PROTECTED]>:
> I think these windowsx macros are confusing things more than helping,
> especially since they don't look like macros. It's better to have
> explicit SendMessage calls than some pseudo function calls, it makes
> much more obvious what's going on,
Robert Shearman <[EMAIL PROTECTED]> writes:
> It seemed to be ignored by both you and Alexandre last time it was
> sent, and all of your patches applied anyway despite objections from
> several developers.
I think these windowsx macros are confusing things more than helping,
especially since they
Robert Shearman wrote:
We're trying to work around GCC warnings that probably aren't generated
> using any other compiler so using non-portable C
> constructs is perfectly fine. Here is Francois' solution again:
I understand Francois's solution, as I mentioned that the gcc guys
proposed it i
Mike McCormack wrote:
Robert Shearman wrote:
Why don't we fix the macros as suggested by Francois, rather than
preventing its use? It seems like a big waste of time to have submitted
all of the patches to the files using windowsx.h when fixing the macros
is necessary for Winelib anyway.
No
Robert Shearman wrote:
Why don't we fix the macros as suggested by Francois, rather than
preventing its use? It seems like a big waste of time to have submitted
all of the patches to the files using windowsx.h when fixing the macros
is necessary for Winelib anyway.
No, it's not a waste of tim
Robert Shearman wrote:
> Mike McCormack wrote:
>
>
>> +#ifdef __WINESRC__
>> +/* This file contains macros that cause warnings on gcc 4.1, so avoid it. */
>> +#error Please avoid use of windowsx.h in Wine source code.
>> +#endif
>> +
>>
>>
>
> Why don't we fix the macros as suggested by Fr
Mike McCormack wrote:
>+#ifdef __WINESRC__
>+/* This file contains macros that cause warnings on gcc 4.1, so avoid it. */
>+#error Please avoid use of windowsx.h in Wine source code.
>+#endif
>+
>
Why don't we fix the macros as suggested by Francois, rather than
preventing its use? It seems like
