RE: Possibility of adding a new patch status

2013-08-14 Thread Hugh McMaster
On Thursday, 1 August 2013 12:19 AM, Vincent Povirk wrote: >The problem is there are situations where patches are never reviewed and no >one is told why. After some thought, it occurred to me that the said patches are being reviewed; they just never have their status altered. So, one possible w

RE: Possibility of adding a new patch status

2013-08-01 Thread Hugh McMaster
>>> * The patch is difficult to review, and he's putting it off. >> >> There are some statuses (e.g. 'needs splitting) to counteract this. But >> patches are/can be difficult to review. Again, a status such as 'Not yet >> reviewed' would help. >> >>> * He's travelling and does not have access t

Re: Possibility of adding a new patch status

2013-07-31 Thread Vincent Povirk
> Wouldn't these two points simply earn a 'Rejected' status and/or some kind of > comment on the wine-devel list? Applying a "Rejected" status would require looking at the patch. But it could be nice to have a status that means "I will not even read a patch from this person to do this specific t

RE: Possibility of adding a new patch status

2013-07-31 Thread Hugh McMaster
Hi Vincent, You raise some very good points. On Wednesday, 31 July 2013 2:53 AM, Vincent Povirk wrote: >I think I've seen patches stay in the "New" state in the following cases: > * He's convinced you do not have the ability to write a patch he would > accept. (There's a common pattern where pe

RE: Possibility of adding a new patch status

2013-07-31 Thread Hugh McMaster
On Tuesday, 30 July 2013 9:04 PM, Ken Sharp wrote: >There's also "Pending". Hi Ken, Yes, I know about the 'Pending' status. The patches page describes this status in two ways: 1. The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of

Re: Possibility of adding a new patch status

2013-07-30 Thread Vincent Povirk
I think I've seen patches stay in the "New" state in the following cases: * He's convinced you do not have the ability to write a patch he would accept. (There's a common pattern where people will take feedback and attempt to revise their patch to account for it, but not really understand the feed

Re: Possibility of adding a new patch status

2013-07-30 Thread Ken Sharp
There's also "Pending". On 30/07/13 04:16, Hugh McMaster wrote: Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked

Possibility of adding a new patch status

2013-07-29 Thread Hugh McMaster
Hi everyone, Wine patches currently have a status described in http://source.winehq.org/patches, yet for patches with the status of 'New', the status becomes confusing. The legend describes 'New' status as "Patch not even looked at yet, there's still hope...". This is ideal for new patches sub