Re: Patch for bug 34388

2013-09-07 Thread Juan Lang
On Fri, Sep 6, 2013 at 9:17 PM, Charles Davis wrote: > > On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > >> Maybe then the real fix is to make Wine accept either a constructor SET >> or the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it curr

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I should come up w

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I should come up with a test case first, though, to > see if that's

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 1:10 PM, Juan Lang wrote: > Hiya Chip, > > I don't have an answer off the top of my head. But let's see if we can unpack > that ASN.1 a bit. > > First, with the type, notice that crypt32_private.h defines a few useful > types that Microsoft omitted for some reason from thei

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
Hiya Chip, I don't have an answer off the top of my head. But let's see if we can unpack that ASN.1 a bit. First, with the type, notice that crypt32_private.h defines a few useful types that Microsoft omitted for some reason from their public header, including: #define ASN_SETOF (ASN_UN

Patch for bug 34388

2013-09-05 Thread Charles Davis
Hi Juan, I need some advice. Attached is a patch to fix bug 34388, where an app that tries to verify its code signature fails because Wine, while parsing the certificates embedded within the signature, encounters an item in the CMS signer info (tag 0x31, i.e. ASN_UNIVERSAL | ASN_CONSTRUCTOR |