Re: Patch for adding Swedish localization

2007-10-15 Thread Maarten Lankhorst
Daniel Nylander schreef: > How do I create a patch per file? There are 28 new files that needs to > be commited and one #include per dll/program to be added. Please help me > out, I'm not a developer If you created a git commit, you can undo it with git reset --mixed origin. Then do the following:

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Maarten Lankhorst skrev: > Hi Daniel, > > You must add localizations for 1 dll/program at a time, that makes it a > lot easier to review. How do I create a patch per file? There are 28 new files that needs to be commited and one #include per dll/program to be added. Please help me out, I'm not a

Re: Patch for adding Swedish localization

2007-10-15 Thread Maarten Lankhorst
Hi Daniel, You must add localizations for 1 dll/program at a time, that makes it a lot easier to review. Cheers, Maarten.

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Robert Shearman skrev: > You need to make one patch with both the changes to existing .rc files > and with the new .rc files, otherwise the commit isn't atomic. > > Also, don't gzip a patch unless it is over ~100KB since it makes it much > harder to review. Here is another shot at it. http://ho

Re: Patch for adding Swedish localization

2007-10-15 Thread Robert Shearman
Daniel Nylander wrote: > Robert Shearman skrev: > >> Daniel Nylander wrote: >> >>> Here is the patch to add Swedish localization files to Wine. >>> Sorry, this is my first patch using git and I'm really unsure if I did >>> it correctly. >>> >>> >> You need to use git-add to includ

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Robert Shearman skrev: > Daniel Nylander wrote: >> Here is the patch to add Swedish localization files to Wine. >> Sorry, this is my first patch using git and I'm really unsure if I did >> it correctly. >> > > You need to use git-add to include the new files in the commit/patch you > sent. Hmm

Re: Patch for adding Swedish localization

2007-10-15 Thread Robert Shearman
Daniel Nylander wrote: > Here is the patch to add Swedish localization files to Wine. > Sorry, this is my first patch using git and I'm really unsure if I did > it correctly. > You need to use git-add to include the new files in the commit/patch you sent. -- Rob Shearman