2010/1/8 Wolfram Sang :
> Geoffrey Hausheer wrote:
>
>> Would someone mind reviewing this for style/content? I still have no
>
> Can't say much about the content, but stylewise the pointer handling
> could be improved. For example,
>
> + if ( (iface==0) || (ppvObject==0) )
>
> should at least u
Geoffrey Hausheer wrote:
> Would someone mind reviewing this for style/content? I still have no
Can't say much about the content, but stylewise the pointer handling
could be improved. For example,
+if ( (iface==0) || (ppvObject==0) )
should at least use NULL instead of 0 as both are pointe
Ok, I have reimplemented OleCreatePropertyFrame() from scratch. There
is no code from Hidenori's patch in mine, nor did I use it as a
reference (though of course I can't claim that I didn't learn anything
from his patch during my previous cleanup)
Would someone mind reviewing this for style/conte
On Mon, Jan 4, 2010 at 7:18 PM, Geoffrey Hausheer
wrote:
> On Mon, Jan 4, 2010 at 9:06 AM, Wolfram Sang wrote:
>>> task. There doesn't appear to be anything in this code that would be
>>> patent encumbered, but the code itself certainly falls under
>>> Hidenori's copyright which he has effective
On Mon, Jan 4, 2010 at 9:06 AM, Wolfram Sang wrote:
>> task. There doesn't appear to be anything in this code that would be
>> patent encumbered, but the code itself certainly falls under
>> Hidenori's copyright which he has effectively revoked permission to
>> use.
>
> Strictly speaking, this is
task. There doesn't appear to be anything in this code that would be
patent encumbered, but the code itself certainly falls under
Hidenori's copyright which he has effectively revoked permission to
use.
Strictly speaking, this is not possible. Although IANAL, this code is
LGPL, so he can't r
On Mon, Jan 4, 2010 at 4:39 AM, John Klehm wrote:
> On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies wrote:
>> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
>>> I found a patch from 2001 written by TAKESHIMA Hidenori that
>>> was posted to wine-patches
>>> (http://www.winehq.org/pip
On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies wrote:
> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
>> I found a patch from 2001 written by TAKESHIMA Hidenori that
>> was posted to wine-patches
>> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html)
>> but nev
On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
> I found a patch from 2001 written by TAKESHIMA Hidenori that
> was posted to wine-patches
> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html)
> but never committed.
Actually it was commited (2843934af5515c7f
Hi Geoffrey,
2010/1/4 Geoffrey Hausheer :
> Some software I'm using is configured via an OleCreatePropertyFrame
> call which isn't implemented in Wine (ticket #16564). I can use
> winetricks + dcom98 to get it working, but would prefer not to need
> that. I found a patch from 2001 written by TAK
Some software I'm using is configured via an OleCreatePropertyFrame
call which isn't implemented in Wine (ticket #16564). I can use
winetricks + dcom98 to get it working, but would prefer not to need
that. I found a patch from 2001 written by TAKESHIMA Hidenori that
was posted to wine-patches
(ht
Fredag 03 juli 2009 11:10:01 skrev Nikolay Sivov:
> Alexander Nicolaysen Sørnes wrote:
> > Hello,
> >
> > Could someone give me a hint as to what is wrong with the following
> > patches?
> >
> > http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html
> > http://www.winehq.org/pipermail/w
Alexander Nicolaysen Sørnes wrote:
Hello,
Could someone give me a hint as to what is wrong with the following patches?
http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html
http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html
They only adds some defines plus a stub,
Hello,
Could someone give me a hint as to what is wrong with the following patches?
http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html
http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html
They only adds some defines plus a stub, so hopefully there isn't that much I
On Fri, Jan 9, 2009 at 9:52 AM, ricardo filipe
wrote:
>
>
>>>"How should I attempt to test the changes I have made"
>> I don't see testcases for any of these changes. Adding conformance
>> tests would be the best first course of action:
>>
>> http://wiki.winehq.org/ConformanceTests
>> http://wiki.
>>"How should I attempt to test the changes I have made"
> I don't see testcases for any of these changes. Adding conformance
> tests would be the best first course of action:
>
> http://wiki.winehq.org/ConformanceTests
> http://wiki.winehq.org/WritingConformanceTests
>
> --
> -Austin
>
>
he is
On Fri, Jan 9, 2009 at 3:18 AM, Andrew Nguyen wrote:
> Hello,
>
> I've written a few patches against dlls/msi/action.c in an effort to
> rectify a difference in behavior with an MSI-based installer between
> Windows and Wine with regard to environment variable processing.
> Behavior not explicitly
Hello,
I've written a few patches against dlls/msi/action.c in an effort to
rectify a difference in behavior with an MSI-based installer between
Windows and Wine with regard to environment variable processing.
Behavior not explicitly enumerated by MSDN is noted when a combination
of the environmen
Hi Alistair,
Alistair Leslie-Hughes wrote:
> Hi,
>
> Is there anything wrong with patches?
>
> [1/2] mshtml: Implement IHTMLScriptElement get/put event
>
> [2/2] mshtml: Implement IHTMLScriptElement get/put htmlFor
>
>
First of all, are you trying to fix a real bug? We're starting to handle
s
Hi,
Is there anything wrong with patches?
[1/2] mshtml: Implement IHTMLScriptElement get/put event
[2/2] mshtml: Implement IHTMLScriptElement get/put htmlFor
Best Regards
Alistair Leslie-Hughes
Lei Zhang a écrit :
> On Sun, Jul 6, 2008 at 6:55 AM, Alexander Nicolaysen Sørnes
> <[EMAIL PROTECTED]> wrote:
>
>> Hello,
>>
>> I would really appreciate any feedback as to how these patches can be
>> improved
>> so that they will be accepted into Wine.
>>
>> regedit: Add support for importing
On Sun, Jul 6, 2008 at 6:55 AM, Alexander Nicolaysen Sørnes
<[EMAIL PROTECTED]> wrote:
> Hello,
>
> I would really appreciate any feedback as to how these patches can be improved
> so that they will be accepted into Wine.
>
> regedit: Add support for importing Unicode files
> http://www.winehq.org/
Hello,
I would really appreciate any feedback as to how these patches can be improved
so that they will be accepted into Wine.
regedit: Add support for importing Unicode files
http://www.winehq.org/pipermail/wine-patches/2008-June/056856.html
I know this patch is a little big, but I'm not sure
Damjan Jovanovic <[EMAIL PROTECTED]> writes:
> +classKey = SetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS,
> + DIOCR_INSTALLER, NULL, NULL);
> +/* wine does incorrectly return FALSE, so ... */
> +ok(classKey != FALSE && classKey
Hi
I've tried submitting a patch to wine-patches 3 times
now in the past 3 weeks, and not only has it not been
applied, but I never even got any feedback.
Please tell me what I am doing wrong.
The latest patch is below.
Thank you
Damjan
--- Damjan Jovanovic <[EMAIL PROTECTED]> wrote:
> Date:
On Tuesday 13 June 2006 18:39, Jason Green wrote:
> On 6/13/06, H. Verbeet <[EMAIL PROTECTED]> wrote:
> > On 13/06/06, Raphael <[EMAIL PROTECTED]> wrote:
> > > I only have one question:
> > > i see you have a cache to reuse prgid in set_glsl_shader_program but
> > > what happens if user/app chang
On 13/06/06, Jason Green <[EMAIL PROTECTED]> wrote:
From what I can tell (for DX9 at least), the app shouldn't be able to
use SetFunction().
You're right.
On 6/13/06, H. Verbeet <[EMAIL PROTECTED]> wrote:
On 13/06/06, Raphael <[EMAIL PROTECTED]> wrote:
> I only have one question:
> i see you have a cache to reuse prgid in set_glsl_shader_program but what
> happens if user/app change the shaders content (for example using
> SetFunction) ? your pre
On 13/06/06, Raphael <[EMAIL PROTECTED]> wrote:
I only have one question:
i see you have a cache to reuse prgid in set_glsl_shader_program but what
happens if user/app change the shaders content (for example using
SetFunction) ? your pre-compiled program will be correct ?
(because i don't see a
On Thursday 08 June 2006 17:35, Jason Green wrote:
> The current cumulative patch is located here:
>
> http://cmhousing.net/wine/glsl_cumul.diff
>
I hate you, reviewing all this patch made me crazy.
Anyway is an impressive work
I only have one question:
i see you have a cache to reuse prgid i
+ * If a program for the given combination does not exist, create one, and store
+ * that data in both shader objects so we can delete all of the programs later.
+ * If it creates a program, it will link the given objects, too.
Is this comment still relevant?
- Fix relative addressing (it was
That looks very impressive (good progress).
I would have to look at the actual GLSL produced by this.
The actual translation points look good.
From: "Jason Green" <[EMAIL PROTECTED]>
Date: Thu, 8 Jun 2006 11:54:04 -0400
By the way, here's a comparison screenshot of Civ4 from before my hard
dri
By the way, here's a comparison screenshot of Civ4 from before my hard
drive failed, and this is without having texturing on pixel shaders
entirely working. Using GLSL (working completely for vertex shaders
2.0, at least the instructions that Civilization 4 used):
http://cmhousing.net/wine/civ4_
The current cumulative patch is located here:
http://cmhousing.net/wine/glsl_cumul.diff
(This includes the recently submitted "Split constant loading out of
drawPrim()" patch, which hasn't been applied to git yet)
Before submitting, I plan to fix the following things:
- Fix relative addressing
34 matches
Mail list logo
