Re: Patch: winex11drv create_cursor Loading 32bit rgba cursor image

2006-06-27 Thread Louis Lenders
Mike Hearn plan99.net> writes: > > Heya Pauli, > > A review is enclosed. To submit a patch please send it to > the wine-patches list, where it'll enter Alexandres queue for review. > > Firstly I'm kind of surprised this doesn't require the XCursor extension. > Handling the case of a solid alph

Re: Patch: winex11drv create_cursor Loading 32bit rgba cursor image

2006-06-25 Thread Mike Hearn
Heya Pauli, A review is enclosed. To submit a patch please send it to the wine-patches list, where it'll enter Alexandres queue for review. Firstly I'm kind of surprised this doesn't require the XCursor extension. Handling the case of a solid alpha channel by converting it to a mask is fine but y

Re: Patch: winex11drv create_cursor Loading 32bit rgba cursor image

2006-06-25 Thread Pauli
I looked the code bit more. Then I thought I hate if and removed some of them. Now I think code is cleaner but it has minor performance hit when cursor don't have alpha. But create_cursor won't be called every frame. ? dlls/winex11.drv/.mouse.c.swp Index: dlls/winex11.drv/mouse.c ==

Patch: winex11drv create_cursor Loading 32bit rgba cursor image

2006-06-24 Thread Pauli
fix for bug 5486 Patch makes it possible to load and display 32bit rgba cursor. I have made tested the code with Football Manager 2006. The ealier version of patch was confimed loading 32bit cursors from Guild Wars. I would like to hear comments how to improve the code. Is there chance that this