On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote:
> On Fri, 03 Aug 2007 01:43:05 +0200, James Hawkins <[EMAIL PROTECTED]>
> wrote:
>
> > On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote:
> >> On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]>
> >> wrote:
> >>
> >> >> Thank you. Hop
On Fri, 03 Aug 2007 01:43:05 +0200, James Hawkins <[EMAIL PROTECTED]>
wrote:
On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote:
On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]>
wrote:
>> Thank you. Hope it will be better this time. Also, I'll send a test
>> if this is OK.
On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote:
> On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> wrote:
>
> >> Thank you. Hope it will be better this time. Also, I'll send a test
> >> if this is OK.
> >
> > This one looks pretty good to me, but I have one error and a few nits
On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> wrote:
Thank you. Hope it will be better this time. Also, I'll send a test
if this is OK.
This one looks pretty good to me, but I have one error and a few nits
to correct:
The error:
+ {
+ERR("GetLocaleInfo of 0x%x failed
> Thank you. Hope it will be better this time. Also, I'll send a test
> if this is OK.
This one looks pretty good to me, but I have one error and a few nits
to correct:
The error:
+ {
+ERR("GetLocaleInfo of 0x%x failed in 2nd stage?!\n", localeValue);
+SysFreeString(*pbstrOut);
You shou
On Tue, 31 Jul 2007 17:38:18 +0200, Juan Lang <[EMAIL PROTECTED]> wrote:
Hi Jiri,
I want to ask, is anything wrong with this patch?
Your indenting is haphazard. Please match the indenting in the rest
of the file, which in this case is no tabs, 2-space indenting. Also,
curly braces go on a
Hi Jiri,
> I want to ask, is anything wrong with this patch?
Your indenting is haphazard. Please match the indenting in the rest
of the file, which in this case is no tabs, 2-space indenting. Also,
curly braces go on a new line, so e.g.:
+ if (!size) {
should be
+ if (!size)
+ {
instead.
--
Hello,
I want to ask, is anything wrong with this patch?
http://www.winehq.org/pipermail/wine-patches/2007-July/041434.html
I'm asking because I have other patches, but don't know if it is
worthwhile to send them.
Regards
Jiri Palecek
