Re: PATCH: handle NULL XImage in GetBitmapBits

2005-12-13 Thread Marcus Meissner
On Tue, Dec 13, 2005 at 07:13:00PM +0100, Willie Sippel wrote: > Am Dienstag, 13. Dezember 2005 11:42 schrieb Alexandre Julliard: > > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > Changelog: > > > In GetBitmapBits() handle the correct bitmap information > > > when a DIB is used. > > > > I t

Re: PATCH: handle NULL XImage in GetBitmapBits

2005-12-13 Thread Willie Sippel
Am Dienstag, 13. Dezember 2005 11:42 schrieb Alexandre Julliard: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > Changelog: > > In GetBitmapBits() handle the correct bitmap information > > when a DIB is used. > > I think for a DIB we want to copy the bits directly, like we already > do in

Re: PATCH: handle NULL XImage in GetBitmapBits

2005-12-13 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > Changelog: > In GetBitmapBits() handle the correct bitmap information > when a DIB is used. I think for a DIB we want to copy the bits directly, like we already do in SetBitmapBits. Does this work for you? diff --git a/dlls/gdi/bitmap.c b

Re: PATCH: handle NULL XImage in GetBitmapBits

2005-12-12 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > Hi, > > This fixes bug 4034. > XGetImage() returns NULL since we can pass a 0 height value. (298 bytes > vs 320 byte wide image). This shouldn't happen, the height should have been checked in GetBitmapBits already. There's something wrong here... --