Re: PATCH: better freetype enc fix

2003-10-26 Thread Rein Klazes
On Sun, 26 Oct 2003 12:47:40 +0100, you wrote: > > FT_ENCODING_MS_SYMBOL is a enum value, not a define, so this check will not work. > > Might need another autoconf check, but for a fixed define its a bit overkill. I agree. Rein -- Rein Klazes [EMAIL PROTECTED]

Re: PATCH: better freetype enc fix

2003-10-26 Thread Marcus Meissner
On Sun, Oct 26, 2003 at 12:28:34PM +0100, Rein Klazes wrote: > On Sun, 26 Oct 2003 12:00:51 +0100, you wrote: > > > hmm, and: > > #define ft_encoding_symbol FT_ENCODING_MS_SYMBOL > > > > Well, what about this patch instead: > > [patch] > > Yes, I like this one better, but the ft_encod

Re: PATCH: better freetype enc fix

2003-10-26 Thread Rein Klazes
On Sun, 26 Oct 2003 12:00:51 +0100, you wrote: > hmm, and: > #define ft_encoding_symbol FT_ENCODING_MS_SYMBOL > > Well, what about this patch instead: [patch] Yes, I like this one better, but the ft_encoding macros are deprecated. What about doing: #ifndef FT_ENCODING_MS_SYMBOL #defi

Re: PATCH: better freetype enc fix

2003-10-26 Thread Marcus Meissner
On Sun, Oct 26, 2003 at 11:29:28AM +0100, Rein Klazes wrote: > On Sun, 26 Oct 2003 10:58:05 +0100, you wrote: > > > Hi, > > > > This fix supercedes Rein Klazes fix, since MS_MAKE_TAG is used in other places. > > Hmm thanks, I shoud have chacked that of course. > > Actually I was expecting the q

Re: PATCH: better freetype enc fix

2003-10-26 Thread Rein Klazes
On Sun, 26 Oct 2003 10:58:05 +0100, you wrote: > Hi, > > This fix supercedes Rein Klazes fix, since MS_MAKE_TAG is used in other places. Hmm thanks, I shoud have chacked that of course. Actually I was expecting the question why not use the definition in freetype.h that comes with libfreetype? O