Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Marcus Meissner
On Sun, Aug 14, 2005 at 10:27:20PM +0200, Felix Nawothnig wrote: > Marcus Meissner wrote: > >>Yes, but please don't use the IsBad* functions, use a proper exception > >>handler. > >Next try, is this what you imagined. > > The reason for using an exception handler is thread safety - to achieve > t

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Felix Nawothnig
Marcus Meissner wrote: Yes, but please don't use the IsBad* functions, use a proper exception handler. Next try, is this what you imagined. The reason for using an exception handler is thread safety - to achieve that you have to put it around the ATOM_AddAtomA call. Felix

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Marcus Meissner
On Thu, Aug 11, 2005 at 02:52:52PM +0200, Alexandre Julliard wrote: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > So ... now we can: > > > > - fix this program by contacting the developers etc... which is difficult. > > - fix WINE by adding a check. > > > > I can only fix WINE. > > Yes, but

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-11 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > So ... now we can: > > - fix this program by contacting the developers etc... which is difficult. > - fix WINE by adding a check. > > I can only fix WINE. Yes, but please don't use the IsBad* functions, use a proper exception handler. -- Alexandre J

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-11 Thread Marcus Meissner
On Tue, Aug 09, 2005 at 12:13:22PM +0300, Saulius Krasuckas wrote: > * On Tue, 9 Aug 2005, Marcus Meissner wrote: > > > > The Ikea kitchen planner passed 0x for some reason and works > > much better after this patch. > > It if uninitialized memory in a case of MSVC and MSVCRTD, I guess.

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-09 Thread Andreas Mohr
Hi, On Tue, Aug 09, 2005 at 01:32:51PM +0300, Saulius Krasuckas wrote: > * On Tue, 9 Aug 2005, Andreas Mohr wrote: > > * On Tue, Aug 09, 2005 at 12:13:22PM +0300, Saulius Krasuckas wrote: > > > > > > It if uninitialized memory in a case of MSVC and MSVCRTD, I guess. > > > BG in the app. :-)

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-09 Thread Saulius Krasuckas
* On Tue, 9 Aug 2005, Andreas Mohr wrote: > * On Tue, Aug 09, 2005 at 12:13:22PM +0300, Saulius Krasuckas wrote: > > > > It if uninitialized memory in a case of MSVC and MSVCRTD, I guess. > > BG in the app. :-) > > Yup, and AFAIR this gets initialized with 0x0c since that is a > breakpoint

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-09 Thread Andreas Mohr
Hi, On Tue, Aug 09, 2005 at 12:13:22PM +0300, Saulius Krasuckas wrote: > * On Tue, 9 Aug 2005, Marcus Meissner wrote: > > > > The Ikea kitchen planner passed 0x for some reason and works > > much better after this patch. > > It if uninitialized memory in a case of MSVC and MSVCRTD, I gu

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-09 Thread Saulius Krasuckas
* On Tue, 9 Aug 2005, Marcus Meissner wrote: > > The Ikea kitchen planner passed 0x for some reason and works > much better after this patch. It if uninitialized memory in a case of MSVC and MSVCRTD, I guess. BG in the app. :-)