Re: Other W->A crosscalls

2004-09-16 Thread Tony Lambregts
Quoting "Dimitrie O. Paun" <[EMAIL PROTECTED]>: > > Once I got rid of the duplicate calls I ended up with 130. > > What do you mean duplicate calls? Can you give a few examples > of entries that you eliminated? > > -- > Dimi. > This is from the output of wine_crosscalls.pl dlls/winspool/info.

Re: Other W->A crosscalls

2004-09-15 Thread Rolf Kalbermatter
Michael Stefaniuc wrote: >Ok, attached is a modified wine_crosscalls.pl script which use smatch's >abilities better. Also it includes an easy way to check for false >positives. At the moment output from the wine tests is ignored. Also *AW >functions are allowed to call *A funtions so those are exc

Re: Other W->A crosscalls

2004-09-15 Thread Adam Petaccia
I know I'm just a random guy subscribed, but I couldn't help but notice that your tags weren't closed. On Wed, 2004-09-15 at 21:56 -0700, Tony Lambregts wrote: > Michael Stefaniuc wrote > > >Corrected script and output files are attached. Now they are only 178 > >lines of output which brings us

Re: Other W->A crosscalls

2004-09-15 Thread Dimitrie O. Paun
> Once I got rid of the duplicate calls I ended up with 130. What do you mean duplicate calls? Can you give a few examples of entries that you eliminated? -- Dimi.

Re: Other W->A crosscalls

2004-09-15 Thread Tony Lambregts
Michael Stefaniuc wrote >Corrected script and output files are attached. Now they are only 178 >lines of output which brings us damn near to Dimi's number. Once I got rid of the duplicate calls I ended up with 130. Changelog: update Janitorial template to reflect the true number of A->W crossc

Re: Other W->A crosscalls

2004-09-15 Thread Michael Stefaniuc
On Wed, Sep 15, 2004 at 04:56:14PM -0700, Juan Lang wrote: > Michael wrote: > > Also *AW functions are allowed to call *A funtions > > so those are excluded too. > > There seem to be quite a few of these from shell32 > still included: > dlls/shell32/shellpath.c 62 PathAppendAW: call to > PathAppen

Re: Other W->A crosscalls

2004-09-15 Thread Juan Lang
Michael wrote: > Also *AW functions are allowed to call *A funtions > so those are excluded too. There seem to be quite a few of these from shell32 still included: dlls/shell32/shellpath.c 62 PathAppendAW: call to PathAppendA dlls/shell32/shellpath.c 75 PathCombineAW: call to PathCombineA dlls/she

Re: Other W->A crosscalls

2004-09-15 Thread Michael Stefaniuc
On Tue, Sep 14, 2004 at 05:43:46PM -0400, Dimitrie O. Paun wrote: > On Tue, Sep 14, 2004 at 11:22:46PM +0200, Michael Stefaniuc wrote: > > How did you generated this list? By manualy working through the list > > generated by Vincent's smatch script or by modifying the script > > directly? > > By m

Re: Other W->A crosscalls

2004-09-14 Thread Dimitrie O. Paun
On Tue, Sep 14, 2004 at 11:22:46PM +0200, Michael Stefaniuc wrote: > How did you generated this list? By manualy working through the list > generated by Vincent's smatch script or by modifying the script > directly? By manually working through the list, yes. -- Dimi.

Re: Other W->A crosscalls

2004-09-14 Thread Michael Stefaniuc
On Mon, Sep 13, 2004 at 12:57:57AM -0400, Dimitrie O. Paun wrote: > On Wed, Aug 25, 2004 at 02:17:22PM -0400, Vincent Béron wrote: > > That was with current CVS, before Alexandre last commits :) > > Yes, they did disappear. Attached is a revised log. > > Here is a somewhat cleaned up list. It's no

Re: Other W->A crosscalls

2004-09-12 Thread Dimitrie O. Paun
On Wed, Aug 25, 2004 at 02:17:22PM -0400, Vincent Béron wrote: > That was with current CVS, before Alexandre last commits :) > Yes, they did disappear. Attached is a revised log. Here is a somewhat cleaned up list. It's not too bad it seems, at 144 entries: crypt.c 514 CryptAcquireContextW: call

Re: Other W->A crosscalls

2004-08-28 Thread Francois Gouget
On Wed, 25 Aug 2004, Rolf Kalbermatter wrote: [...] > I see many "xxxAW calls xxxA function" mainly in the shell related DLLs. This > is of course not something you can really get rid of, so the script should > be able to exclude those cases. I couldn't test as I don't have smatch, but I think tha

Re: Other W->A crosscalls

2004-08-25 Thread Rolf Kalbermatter
Vincent Beron wrote: >I attach the smatch script to generate the results I have. It's still >not perfect (the listview.c references are wrong, for example), but as >it's tied to gcc it can detect some calls which otherwise would not be >caught. For example, the calls to GetWindowLongA in header.c

Re: Other W->A crosscalls

2004-08-25 Thread Vincent Béron
Le mer 25/08/2004 à 14:03, Robert Shearman a écrit : > Vincent Béron wrote: > > >I played a bit with smatch and Wine (after reading > >http://people.redhat.com/mstefani/wine/smatch/), to try to get over what > >I mentionned in my last email (regarding winapi_check and cross-calls in > >parenthesis

Re: Other W->A crosscalls

2004-08-25 Thread Robert Shearman
Vincent Béron wrote: I played a bit with smatch and Wine (after reading http://people.redhat.com/mstefani/wine/smatch/), to try to get over what I mentionned in my last email (regarding winapi_check and cross-calls in parenthesis). I attach the smatch script to generate the results I have. It's sti

Other W->A crosscalls

2004-08-25 Thread Vincent Béron
I played a bit with smatch and Wine (after reading http://people.redhat.com/mstefani/wine/smatch/), to try to get over what I mentionned in my last email (regarding winapi_check and cross-calls in parenthesis). I attach the smatch script to generate the results I have. It's still not perfect (the