Doh! The page faults were caused by me using GlobalUnlock instead of
GlobalUnlock16. Seems to be working now, sending new version to
wine-patches :)
Mike McCormack wrote:
Typing too fast on IRC, probably ;)
Dmitry is correct, it should be GlobalUnlock16(hTask).
Mike
Hmm, but then there are page faults.
I'll have to take a closer look at task.c to see what's going on...
Joseph Garvin wrote:
Dmitry Timoshkov wrote:
And GlobalUnlock(tdb) is not right at all, you want
GlobalUnlock16(hTask).
Mike walked me through the patch, I'm not sure what his reasoning was on
unlocking tdb versus hTask.
Typing too fast on IRC, probably ;)
Dmitry is correct, it should be
Dmitry Timoshkov wrote:
And GlobalUnlock(tdb) is not right at all, you want
GlobalUnlock16(hTask).
I resent it a second later with the 'x' fix. That does look more
correct, but strangely the patch as is works. If I make your change the
application I'm trying to fix gives this:
err:heap:
"Joseph Garvin" <[EMAIL PROTECTED]> wrote:
+/* Correct if instance is null now, because later we won't
+ be able to tell the difference between a 16-bit NULL and
+ a 32-bit NULL */
+
+if (!instance)
+{
+HTASK16 hTask = GetCurrentTask();
+TDB *tdb = Globa
