Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-06 Thread Fabian Cenedese
At 12:58 06.02.2004 -0500, Kirill Smelkov wrote: >On Fri, 6 Feb 2004, Fabian Cenedese wrote: > >[...] >> >I can't help you until i see how your app is supposed to work. >> >Please make sure the programm runs without (header[1]==0). >> >> That's the point, it doesn't work on wine in the current stat

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-06 Thread Kirill Smelkov
On Fri, 6 Feb 2004, Fabian Cenedese wrote: [...] > >I can't help you until i see how your app is supposed to work. > >Please make sure the programm runs without (header[1]==0). > > That's the point, it doesn't work on wine in the current state. That's why > I try to fix wine. Use my patch (even if

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-06 Thread Fabian Cenedese
>> Where did you disable it? My patch or yours? With my patch it should >> never even get to try to call CreateIcon (which fails). So either the >> field is not 0 or you don't jump out. > >I juste removed my header[1]==1, so you can say i rejected my patch. > >> >MessageBox with >> >"Failed to loa

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-05 Thread Kirill Smelkov
Fabi, I'm sorry for the delay in sending you this... [snip] > > > >Fabi, > > > >I temporarly disable checking for (header[1]==0). even in such case your > >test-case doesn't start: [snip] > > Where did you disable it? My patch or yours? With my patch it should > never even get to try to call Crea

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-04 Thread Fabian Cenedese
>> >Then what type of picture it is? >> > >> >0x4947 GIF >> >0xd8ff JPEG >> >0x4d42 BMP >> >0x ICON >> >0x746c ??? >> >> Well, as I didn't use any pictures I don't know what it's supposed to be. >> Might as well be "NoPic" :) But I have also seen this marker where the >> second field was

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-04 Thread Kirill Smelkov
On Tue, 3 Feb 2004, Fabian Cenedese wrote: > > >> >> This fails on on my computer and I don't > >> >> know how wine could detect if it's a headerless picture or no picture at all > >> >> if they look the same (so far). > >> > > >> >Maybe check header[0] to be real .bmp or .gif magic and header[1]

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Fabian Cenedese
>> >> This fails on on my computer and I don't >> >> know how wine could detect if it's a headerless picture or no picture at all >> >> if they look the same (so far). >> > >> >Maybe check header[0] to be real .bmp or .gif magic and header[1] for >> >zero? >> >> I couldn't see a difference, always

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Kirill Smelkov
On Tue, 3 Feb 2004, Fabian Cenedese wrote: > > >> >In my case there are lots of *.bmp (with picture) with exactly same header > >> >i mentioned. Thus header[1]==0 doesnt imply 'there is no picture at all' > >> > > >> >This pictures came in ole storage taken from a real win32 app, and loading > >>

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Fabian Cenedese
>> >In my case there are lots of *.bmp (with picture) with exactly same header >> >i mentioned. Thus header[1]==0 doesnt imply 'there is no picture at all' >> > >> >This pictures came in ole storage taken from a real win32 app, and loading >> >them on windows works correctly. >> >> Do you have VB6

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Kirill Smelkov
On Tue, 3 Feb 2004, Fabian Cenedese wrote: > > >> I don't think that this is correct. If header[1] is 0 then it means that there is > >> no picture at > >> all, and not a picture without header (me thinks). When trying to start a program > >> that uses > >> the SSTab from TabCtl32.ocx without ha

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Fabian Cenedese
>> I don't think that this is correct. If header[1] is 0 then it means that there is >> no picture at >> all, and not a picture without header (me thinks). When trying to start a program >> that uses >> the SSTab from TabCtl32.ocx without having assigned icons to the tabs it fails >> because >>

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Kirill Smelkov
On Tue, 3 Feb 2004, Fabian Cenedese wrote: > > >Hi, > >In my case headerless bitmaps have > >{ 0x42, 0x4d, 0x9c, 0xbd, 0x00, 0x00, 0x00, 0x00 } first 8 bytes. > > > >So, when last four are equal to zero its 'no header' case. > > > >Change

Re: OLEPictureImpl_Load: fix for headerless pictures

2004-02-03 Thread Fabian Cenedese
>Hi, >In my case headerless bitmaps have >{ 0x42, 0x4d, 0x9c, 0xbd, 0x00, 0x00, 0x00, 0x00 } first 8 bytes. > >So, when last four are equal to zero its 'no header' case. > >ChangeLog: > OLEPictureImpl_Load: fix for headerless pictures &g