On Wed, Jul 2, 2008 at 10:52 AM, Adam Petaccia <[EMAIL PROTECTED]> wrote:
> I don't like being able to do commit -a either, since valgrind errors
> are considered serious, should the patch be merged upstream?
Alexandre didn't like the patch for some reason earlier.
I will have a look and see if I
On Wed, 2008-07-02 at 10:57 -0500, James Hawkins wrote:
> On Wed, Jul 2, 2008 at 9:40 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> > Hi James,
> > could you have a look at yet more fresh valgrind warnings, triggered by
> > http://source.winehq.org/git/wine.git/?a=commit;h=d9ac95be5bb51de2293326920c2e
On Wed, Jul 2, 2008 at 11:30 AM, Juan Lang <[EMAIL PROTECTED]> wrote:
>> Besides, using valgrind is still a pita, and your patch makes it easier, but
>> it keeps
>> me from being able to 'commit -a'.
>
> Why does it prevent that? I just do one junk commit of the valgrind
> patch, and ignore it wh
> Besides, using valgrind is still a pita, and your patch makes it easier, but
> it keeps
> me from being able to 'commit -a'.
Why does it prevent that? I just do one junk commit of the valgrind
patch, and ignore it when I send in my changes.
--Juan
On Wed, Jul 2, 2008 at 9:40 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> Hi James,
> could you have a look at yet more fresh valgrind warnings, triggered by
> http://source.winehq.org/git/wine.git/?a=commit;h=d9ac95be5bb51de2293326920c2eb4509834ff93
> ?
>
> You might want to invest in a copy of Valgr
Hi James,
could you have a look at yet more fresh valgrind warnings, triggered by
http://source.winehq.org/git/wine.git/?a=commit;h=d9ac95be5bb51de2293326920c2eb4509834ff93
?
You might want to invest in a copy of Valgrind yourself sometime.
I can get you a 10% off discount :-)
http://kegel.com/wi
