Re: New registry key adding patch

2004-02-02 Thread Zimler Attila
Dimitrie O. Paun wrote: On February 2, 2004 03:05 am, you wrote: Yes, I nee help :) It's the old problem :) what task could I start :) If I saw correctly in the list, regedit is implemented meantime :) We still need to add support for delete/rename of keys. Ok, I all will do it :) (if

Re: New registry key adding patch

2004-01-01 Thread Dimitrie O. Paun
On January 1, 2004 02:35 pm, Zimler Attila wrote: > Am I loaded correctly the string? Could you verify it for me? If yes, I > will send the patch for including in the CVS tree. It seems so, yes. However, I'd change the "new key" string to "New Key" to match the native one (it's also nicer). > If

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Dimitrie O. Paun wrote: You use LoadString() to load the string (look at how we load error strings in edit.c even though there it's simple since the buffer is fixed size for now). Am I loaded correctly the string? Could you verify it for me? If yes, I will send the patch for including in the C

Re: New registry key adding patch

2004-01-01 Thread Dimitrie O. Paun
On January 1, 2004 08:16 am, Zimler Attila wrote: > I don't understand this. Probably because I don't understand how we > translate the "key name" string, to the localized version, and because > this I have no idea how big memory should we allocate. You use LoadString() to load the string (look at

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Hi, I give it a third try :) Dimitrie O. Paun wrote: On January 1, 2004 06:41 am, Zimler Attila wrote: This is working while "key name" string is not localized. After that this could introduce security bugs. Will it be localized? How to deal with situations like this? Well, we would need

Re: New registry key adding patch

2004-01-01 Thread Dimitrie O. Paun
On January 1, 2004 06:41 am, Zimler Attila wrote: > This is working while "key name" string is not localized. > After that this could introduce security bugs. > Will it be localized? How to deal with situations like this? Well, we would need to allocate the buffer dynamically anyway. Please use

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Hi, I tried to remove objectionable codes. Here is the patch again. I used sprintf, because snprintf gives me a warning, that it is explicitly declared (stdio.h is included). This is working while "key name" string is not localized. After that this could introduce security bugs. Will it be local

Re: New registry key adding patch

2003-12-31 Thread Zimler Attila
Dimitrie O. Paun wrote: On December 31, 2003 11:18 am, Zimler Attila wrote: Cool, here are a few comments on the patch: + /* Modified by Attila ZIMLER <[EMAIL PROTECTED]> on 28th of dec 2003. + - New key adding is now supported. + */ Please don't add such stuff in the headers, this g

Re: New registry key adding patch

2003-12-31 Thread Dimitrie O. Paun
On December 31, 2003 11:18 am, Zimler Attila wrote: Cool, here are a few comments on the patch: > + /* Modified by Attila ZIMLER <[EMAIL PROTECTED]> on 28th of dec 2003. > + - New key adding is now supported. > + */ Please don't add such stuff in the headers, this goes automatically in the C

New registry key adding patch

2003-12-31 Thread Zimler Attila
Hi, I made the regedit program able to add new registry key (however, the key does not appear until next run of regedit in the browser tree - as I consulted it with Dimitrie, it will be handled later). The diff is made against todays cvs tree (as 2003 december 31). Attila PS: Dimitrie: what i