> But I've looked through listview tests and it seems to be quite simple
> (much simplier than WinAPI and C appeared to me at the very start :)
> ), so I hope to figure it out.
If you get stuck, send what you have and ask for help. We're trying
to encourage you to keep working on it, so your patc
> The key is to see what happens and if it is what you expected. Can this
> also be emulated in any version of Windows to verify this is what
> happens there?
I hope that clicking listview header and then bumping message to the
application happens in any Windows version. I hope.
Anyway, I do und
> It's up to you how to execute the requested functionality.
> If that's absolutely necessary it's not too hard to send
> WM_LBUTTONDOWN/WM_LBUTTONUP to the control.
...for experienced C programmer. And I am not one. But I'll try.
Dmitry Timoshkov wrote:
> "Igor Tarasov" wrote:
>
>
>> Now I don't get it. Looked through listview tests and there are not
>> even one mouse-related test. And my patch could be tested by just
>> sending HDN_ITEMCLICKW to listview control. And capturing the response
>> notifications.
>>
>
>
"Igor Tarasov" wrote:
> Now I don't get it. Looked through listview tests and there are not
> even one mouse-related test. And my patch could be tested by just
> sending HDN_ITEMCLICKW to listview control. And capturing the response
> notifications.
Then just do it that way.
> But the code is:
>> I just cant think of any regression test for that patch. It should
>> test if the notification is really being forwarded?
> Yes, that's what I mean. You're right, that might be hard, since you
> have to simulate a mouse click.
Now I don't get it. Looked through listview tests and there are not
Hi Igor,
> I just cant think of any regression test for that patch. It should
> test if the notification is really being forwarded?
Yes, that's what I mean. You're right, that might be hard, since you
have to simulate a mouse click.
> And does that mean that tests for the second patch are also
Hi Juan,
Thanks for quick reply.
> A regression test would go a long way toward proving your fix is correct.
There are two problems:
1. I am not that good in C and I have never written any regression tests in C.
2. I just cant think of any regression test for that patch. It should
test if the n
Igor Tarasov a écrit :
> Hello!
>
> I've written 2 patches, and I need advice on both of them.
>
> First one is here:
> http://www.winehq.org/pipermail/wine-patches/2009-February/069463.html
>
> It's a single-line patch that adds forwarding notification that was
> omitted in wine code. This fix loo
Hi Igor,
> It's a single-line patch that adds forwarding notification that was
> omitted in wine code. This fix looks pretty simple, but it included
> lots of reading/testing/debugging, and here is what I came with. And
> as I told there it fixes one wine bugzilla bug.
A regression test would go
Hello!
I've written 2 patches, and I need advice on both of them.
First one is here:
http://www.winehq.org/pipermail/wine-patches/2009-February/069463.html
It's a single-line patch that adds forwarding notification that was
omitted in wine code. This fix looks pretty simple, but it included
lots
11 matches
Mail list logo
