Re: Misc bugs found by using valgrind

2003-10-03 Thread Michael Günnewig
Alexandre Julliard <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Michael Günnewig) writes: > >> It's a point, so here is the new patch. > > I don't think we need to check string sizes against MAXINT, that's > just a waste of time. Okay you're correct, the check isn't necessary as MAXINT * 2 is

Re: Misc bugs found by using valgrind

2003-09-25 Thread Alexandre Julliard
[EMAIL PROTECTED] (Michael Günnewig) writes: > It's a point, so here is the new patch. I don't think we need to check string sizes against MAXINT, that's just a waste of time. Also please don't add memsets to fix valgrind complaints, the bugs need to be fixed properly not just hidden by clearing

Re: Misc bugs found by using valgrind

2003-09-25 Thread Michael Günnewig
Shachar Shemesh <[EMAIL PROTECTED]> writes: > Michael Günnewig wrote: > >>Changelog: >> Fixed use of uninitialized memory and wrong buffersize (found by valgrind). ... > What are we doing to prevent integer overflow on these allocations? > Shouldn't we, perhaps, use some wrapper that checks that

Re: Misc bugs found by using valgrind

2003-09-21 Thread Shachar Shemesh
Michael Günnewig wrote: Changelog: Fixed use of uninitialized memory and wrong buffersize (found by valgrind). Michael --- dlls/avifil32/api.c.SAV 2003-09-20 16:14:45.0 +0200 +++ dlls/avifil32/api.c 2003-09