Re: Make RegisterDeviceNotificationW behave likeRegisterDeviceNotificationA

2008-08-09 Thread Juan Lang
> So is there anything I should do now? Or just wait to see what happens? Wait, as Alexandre's on vacation until the 18th. He'll probably commit this after he gets back, but if you notice a bunch of things getting committed and yours did not and did not get any feedback from him, you can ask agai

Re: Make RegisterDeviceNotificationW behave likeRegisterDeviceNotificationA

2008-08-09 Thread Martin Profittlich
Dmitry Timoshkov wrote: >"Zachary Goldberg" wrote: > >> Your patch is more likely to be accepted if it comes with a test which >> works on windows, didnt pass in wine before but passes now and >> demonstrates why the new behavior is correct. > > There is no need for a test since that's not reall

Re: Make RegisterDeviceNotificationW behave likeRegisterDeviceNotificationA

2008-08-07 Thread Dmitry Timoshkov
"Zachary Goldberg" <[EMAIL PROTECTED]> wrote: > Your patch is more likely to be accepted if it comes with a test which > works on windows, didnt pass in wine before but passes now and > demonstrates why the new behavior is correct. There is no need for a test since that's not really an implementa