Re: msxml3: Correct MSXML Object Safety tests (try 2)

2011-09-05 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > Add the enabled test as well. > > Changelog: > msxml3: Correct Object Safety tests It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4706: Test failed: expecte

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.

2010-01-23 Thread Austin English
On Sat, Jan 23, 2010 at 9:24 AM, Terry wrote: Forgot the patch. -- -Austin

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.

2009-05-20 Thread Austin English
On Tue, May 19, 2009 at 3:07 PM, Judy Devyak wrote: > > > > You forgot the patch. -- -Austin

Re: [3/4] msxml: Implement removeAttribute

2007-11-15 Thread Alistair Leslie-Hughes
Mikołaj Zalewski wrote: > A problem with this patch is that the user may have an IXMLDOMNode * > reference to the attribute node being removed. The xmlFreeProp will free > the xmlnode so accessing the IXMLDOMNode could result in memory > corruption. Under MSXML it's possib

Re: [3/4] msxml: Implement removeAttribute

2007-11-15 Thread Mikołaj Zalewski
A problem with this patch is that the user may have an IXMLDOMNode * reference to the attribute node being removed. The xmlFreeProp will free the xmlnode so accessing the IXMLDOMNode could result in memory corruption. Under MSXML it's possible to access such node and even reconnect i

Re: [4/4] msxml: Test for removeAttribute (try 2)

2007-11-14 Thread James Hawkins
On 11/14/07, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > Hi, > Changelog: > msxml: Test for removeAttribute > You sent the patch to the wrong mailing list. Also, if you send a 'try X' patch, you should write a message saying what you changed from the

Re: [4/4] msxml: Test for removeAttribute (try 2)

2007-11-14 Thread Alistair Leslie-Hughes
Hi, Changelog: msxml: Test for removeAttribute Best Regards Alistair Leslie-Hughes diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 79a70a4..6996cdc 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -1110,6 +1110,16 @@ static void

Re: [4/4] msxml: Test for removeAttribute

2007-11-14 Thread Robert Shearman
Alistair Leslie-Hughes wrote: > @@ -589,6 +589,10 @@ static void test_domnode( void ) > ok( !lstrcmpW(V_BSTR(&var), szstr1), "wrong attr value\n"); > VariantClear( &var ); > SysFreeString( str ); > + > + > +str = SysAllocString( szvr ); > +SysFreeString( s

Re: msxml: Implement cloneNode and correct insertBefore

2007-11-14 Thread Alistair Leslie-Hughes
"James Hawkins" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > On 11/13/07, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: >> >> Hi James, >> Thanks for the pointers. >> >> I resend the patches shortly. Is there an easy way to split a Diff up? >> via >> git? More to the

Re: msxml: Implement cloneNode and correct insertBefore

2007-11-14 Thread Maarten Lankhorst
Hi James, James Hawkins schreef: > mailing list etiquette: make sure to bottom-post on this ML and CC > wine-devel so others can share in the information exchange. > > To answer your question, you have to get into the git mindset. That > is, you make one fix, commit the fix, write the next fix, e

Re: msxml: Implement Element removeAttribute

2007-11-13 Thread Steven Edwards
On Nov 12, 2007 3:57 AM, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > > + > +TRACE("(%p)->%s\n", iface, debugstr_w(p)); > +// TODO Replace if Attribute has a Default value. Also another thing. No C++ style comments in Wine source code. Thanks Steven -- Steven Edwards "There is o

Re: msxml: Implement cloneNode and correct insertBefore

2007-11-13 Thread James Hawkins
On 11/13/07, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > > Hi James, > Thanks for the pointers. > > I resend the patches shortly. Is there an easy way to split a Diff up? via > git? More to the point changes to a single file (without have to backup it > up every change) > > I just g

Re: msxml: Implement cloneNode and correct insertBefore

2007-11-13 Thread James Hawkins
On 11/12/07, Alistair Leslie-Hughes <[EMAIL PROTECTED]> wrote: > Hi, > > Changelog: > InsertBefore is allowed to have outNewChild as NULL > Implement cloneNode > One fix per patch please. Also, please add tests for these fixes. > Best Regards > Alistair Leslie-Hughes > > diff -

Re: msxml - Fix Memory Leak

2007-11-02 Thread Vitaliy Margolen
this work better? Ill forward to the patch list if this works. > > Best Regards > Alistair > > > > > 00 > > From: [EMAIL PROTECTED] > > To: wine-devel@winehq.org > > CC: [EMAIL PROTECTED] > > Subject: Re: msxml - Fix Memory Leak > >

Re: msxml - Fix Memory Leak

2007-11-02 Thread Vitaliy Margolen
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > Fixed memory leak > > > Regards > Alistair Leslie-Hughes > > > begin 666 xmlelem.diff Please attach patches as a plain text. This patch is not an attachment and is unreadable. Vitaliy.

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-10-10 Thread Dan Kegel
On 9/24/06, Tony Lambregts <[EMAIL PROTECTED]> wrote: I just wanted to point out that we have a component wine-gui that is kind of a catch all that seems to include bugs in richedit, ddraw, comctrl, rebar and x11. I believe it would be a good thing if someone could do some janitorial on this to s

Re: Whither msxml?

2006-09-25 Thread Huw Davies
On Sat, Sep 23, 2006 at 05:52:51AM -0700, Dan Kegel wrote: > If anyone has tips on sore spots with Wine's msxml, please > let me know. Hi Dan, There are lots of things that need to be done in msxml3: Currently we have implemented some of the DOM methods, most of these are

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-24 Thread Tony Lambregts
James Hawkins wrote: > On 9/23/06, Tony Lambregts <[EMAIL PROTECTED]> wrote: >> > >> I will add these categories to bugzilla as soon as I can but >> unfortunatly bugzilla and the AppDB and the main site are down since at >> least 9:00 AM MST >> > > Can you also add an 'installer' keyword? This wo

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-24 Thread Tony Lambregts
Tony Lambregts wrote: > Louis Lenders wrote: >>> I propose adding categories for msxml and setupapi now. >>> Here are bugzilla queries that find quite a few bugs that >>> are candidates for moving into those categories: >>> >>> >> Good idea. In

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-24 Thread James Hawkins
On 9/23/06, Tony Lambregts <[EMAIL PROTECTED]> wrote: > I will add these categories to bugzilla as soon as I can but unfortunatly bugzilla and the AppDB and the main site are down since at least 9:00 AM MST Can you also add an 'installer' keyword? This would be helpful in keeping track of all

Re: Whither msxml?

2006-09-24 Thread Vijay Kiran Kamuju
Hi our msxml idl flles are not in sync with psdk idl files. especially it still doesnot have SAX defines. And XML DSO definitions. (this is a bit compilicated). As msxml.idl includes xmldso.idl in PSDK headers. And msxml2.idl defines them in the idl file itself. As there are some

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-24 Thread Tony Lambregts
Louis Lenders wrote: >> I propose adding categories for msxml and setupapi now. >> Here are bugzilla queries that find quite a few bugs that >> are candidates for moving into those categories: >> >> > > Good idea. In case someone is going to add these catagori

Re: Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-23 Thread Louis Lenders
> > I propose adding categories for msxml and setupapi now. > Here are bugzilla queries that find quite a few bugs that > are candidates for moving into those categories: > > Good idea. In case someone is going to add these catagories, please also add catagories for c

Whither msxml?

2006-09-23 Thread Dan Kegel
dig up demo apps and articles that might help us understand where wine's msxml needs to go. Man, oh, man are there a lot of pages about msxml out there. If anyone has tips on sore spots with Wine's msxml, please let me know. A few random notes: MSDN on msxml: http://windowssdk.ms

Please create wine-msxml and wine-setupapi components in bugzilla

2006-09-23 Thread Dan Kegel
Bugzilla currently lacks categories for several important parts of wine. This is natural - nothing's perfect. Rather than fix this all at one go, let's just add categories as we find we need them. I propose adding categories for msxml and setupapi now. Here are bugzilla queries that

Re: [msxml] libuuid

2005-12-02 Thread Huw D M Davies
; > > > I don't think libuuid should contain the msxml2 uuids; at least the > > version I have doesn't. > > > > Huw. > > ?? its only an archive > Only msxml >= 3 uuids seems to need to be redeclared It becomes a problem if we use those uuids in a test suite and then try to compile that test with msvc. Huw.

Re: [msxml] libuuid

2005-12-01 Thread Raphael
ion I have doesn't. > > Huw. ?? its only an archive Only msxml >= 3 uuids seems to need to be redeclared Regards, Raphael pgplMk2aRJSO1.pgp Description: PGP signature

Re: [msxml] libuuid

2005-12-01 Thread Huw D M Davies
On Thu, Dec 01, 2005 at 10:02:25PM +0100, Raphael wrote: > Hi, > > Changelog: > - add needed uuid generation I don't think libuuid should contain the msxml2 uuids; at least the version I have doesn't. Huw.

Re: msxml: remove a few guids

2005-11-07 Thread Huw D M Davies
On Mon, Nov 07, 2005 at 12:31:32PM +, Huw D M Davies wrote: > Huw Davies <[EMAIL PROTECTED]> > Remove a couple of unnecessary guids. Actually could you ignore this for the time being. The guids are needed to get the crosstests to build as mingw lacks these in its libuuid.a Hu

Re: MSXML: add some node tests

2005-08-22 Thread Alexandre Julliard
Mike McCormack <[EMAIL PROTECTED]> writes: > diff -u -p -r1.1 domdoc.c > --- dlls/msxml3/tests/domdoc.c12 Aug 2005 11:25:05 - 1.1 > +++ dlls/msxml3/tests/domdoc.c20 Aug 2005 07:38:47 - > @@ -27,59 +27,65 @@ > #include "xmldom.h" > #include > > +#ifndef STANDALONE

Re: [MSXML]xmlnode_get_nodeName Implementation

2005-08-15 Thread Mike McCormack
Vijay Kiran Kamuju wrote: Do we have to register the IXMLDOMNode to the registry? As you did in the test for domdoc. I think we need to add all other basic interface's CLSID's to the registry? IXMLDOMNode is an interface, which has an IID, not a CLSID. We don't need to register interfaces f

Re: [MSXML]xmlnode_get_nodeName Implementation

2005-08-15 Thread Vijay Kiran Kamuju
Hi Mike, Do we have to register the IXMLDOMNode to the registry? As you did in the test for domdoc. I think we need to add all other basic interface's CLSID's to the registry? Thanks, Vijay On 8/16/05, Mike McCormack <[EMAIL PROTECTED]> wrote: > > Vijay Kiran Kamuju wrote: > > > I am planning

Re: [MSXML]xmlnode_get_nodeName Implementation

2005-08-15 Thread Mike McCormack
Vijay Kiran Kamuju wrote: I am planning to write some tests for IXMLDOMNode. I need your help on how to write tests in the wine test framework and test on the windows framework. I started a simple test case in dlls/msxml3/tests/domdoc.c. I modify it a little bit to get it to compile under M

Re: [MSXML]xmlnode_get_nodeName Implementation

2005-08-15 Thread Vijay Kiran Kamuju
e comment on the patch > > For now the basics of msxml3 aren't really decided (eg. how to map > xmlNodePtr to IXMLDOMNode, etc), and how to manage the relationship > between nodes. The way I'm managing node pointers will probably change > again. > > What I really n

Re: [MSXML]xmlnode_get_nodeName Implementation

2005-08-15 Thread Mike McCormack
nt on the patch For now the basics of msxml3 aren't really decided (eg. how to map xmlNodePtr to IXMLDOMNode, etc), and how to manage the relationship between nodes. The way I'm managing node pointers will probably change again. What I really need is more test cases, so if you have

Re: IE4 support for msxml

2005-07-01 Thread Mike McCormack
Vijay Kiran Kamuju wrote: for backward compatibility, i would be defining the interfaces. as for iid's i would be going for msxml3 implementation. Great! Are there any suggestions for my sample stub implementation? Well, there's a few different styles used in Wine. I've been working on

Re: IE4 support for msxml

2005-07-01 Thread Vijay Kiran Kamuju
y Kiran Kamuju wrote: > > > Are we supporting IE4? > > There are some changes in the interfaces for msxml and also there are > > changes in guids in the subsequent versions. > > > > How to handle ie4 finterface changes in msxml.idl? > > COM gives different int

Re: IE4 support for msxml

2005-07-01 Thread Mike McCormack
Vijay Kiran Kamuju wrote: Are we supporting IE4? There are some changes in the interfaces for msxml and also there are changes in guids in the subsequent versions. How to handle ie4 finterface changes in msxml.idl? COM gives different interfaces different IIDs, so there shouldn't b

IE4 support for msxml

2005-07-01 Thread Vijay Kiran Kamuju
Hi, Are we supporting IE4? There are some changes in the interfaces for msxml and also there are changes in guids in the subsequent versions. How to handle ie4 finterface changes in msxml.idl? Thanks, Vijay

Re: [MSXML] : add declarations for XMLDOM

2005-06-30 Thread Mike McCormack
Hi Vijay, Vijay Kiran Kamuju wrote: I am sending a new patch for th XMLDOM stuff ChangeLog add definitions and declarations for XMLDOM stuff Thanks for sending the patch in. After looking through it, here are my notes: * try cut it up into small bits, the smaller the bett

Re: [MSXML] : add declarations for XMLDOM #1

2005-06-29 Thread Alexandre Julliard
Vijay Kiran Kamuju <[EMAIL PROTECTED]> writes: > This is part-1 of the patch that adds necessary defines for XMLDOM interfaces > for msxml These belong to msxml2did.h. -- Alexandre Julliard [EMAIL PROTECTED]

Re: clarification regarding msxml

2005-06-22 Thread Mike McCormack
Vijay Kiran Kamuju wrote: Can you please clarify what msxml.idl is implementing It's aimed at implementing msxml3.dll, however the declarations should be independent of which version you're using. If you wish to extend the definitions, you should make sure to consult the Microsoft Windows

clarification regarding msxml

2005-06-22 Thread Vijay Kiran Kamuju
Hi, Can you please clarify what msxml.idl is implementing msxml.dll (Version 1.0) comes with IE4.0 or msxml.dll (Version 2.0) or msxml2.dll (Version 2.5/2.6) or msxml3.dll (Version 3.0) Thanks, Vijay

Re: MSXML

2005-06-17 Thread Oliver Stieber
gistered correctly? > > try: > regsvr32 msxml.dll > > Ciao, Marcus > > > 0009:Call advapi32.RegOpenKeyA(8000,77c27a48 > "CLSID\\{7B8A2D94-0AC9-11D1-896C-00C04FB6BFC4}",77a7d46c) > ret=65f3630a > trace:reg:NtOpenKey > (0xb8,L"CLSID\\{7B8A2D94-0AC

Re: MSXML

2005-06-17 Thread Oliver Stieber
--- Marcus Meissner <[EMAIL PROTECTED]> wrote: > On Thu, Jun 16, 2005 at 01:41:07AM +0100, Oliver > Stieber wrote: > > Hi, > > Is MXSML working properly at the moment? > > I've been trying to get render monkey working so > > > > XML Parse Error: > > FIle: data\rm_registry.rfx > > Error Code

Re: MSXML

2005-06-17 Thread Marcus Meissner
On Fri, Jun 17, 2005 at 01:08:18PM +0100, Oliver Stieber wrote: > > > > --- Marcus Meissner <[EMAIL PROTECTED]> wrote: > > > On Thu, Jun 16, 2005 at 01:41:07AM +0100, Oliver > > Stieber wrote: > > > Hi, > > > Is MXSML working properly at the moment? > > > I've been trying to get render monke

Re: MSXML

2005-06-17 Thread Oliver Stieber
--- Marcus Meissner <[EMAIL PROTECTED]> wrote: > On Thu, Jun 16, 2005 at 01:41:07AM +0100, Oliver > Stieber wrote: > > Hi, > > Is MXSML working properly at the moment? > > I've been trying to get render monkey working so > > > > XML Parse Error: > > FIle: data\rm_registry.rfx > > Error Code

Re: MSXML

2005-06-17 Thread Troy Rollo
> On Thu, Jun 16, 2005 at 01:41:07AM +0100, Oliver Stieber wrote: > > Hi, > > Is MXSML working properly at the moment? > > I've been trying to get render monkey working so I can > > do some more testing on vertex shaders but if fails > > with the following

Re: MSXML

2005-06-16 Thread Marcus Meissner
On Thu, Jun 16, 2005 at 01:41:07AM +0100, Oliver Stieber wrote: > Hi, > Is MXSML working properly at the moment? > I've been trying to get render monkey working so I can > do some more testing on vertex shaders but if fails > with the following error: > > XML Parse Error: > FIle: data\rm_regist

MSXML

2005-06-15 Thread Oliver Stieber
http://www.ati.com/developer/rendermonkey/ The wise installer failed and I had to install it with cedega. msi can be downloaded from http://66.102.9.104/search?q=cache:4xibXp6MrE0J:www.microsoft.com/downloads/details.aspx%3FFamilyID%3D3144b72b-b4f2-46da-b4b6-c5d7485f2b42%26DisplayLang%3Den+msxml+downlo

Re: MSXML: add some idl definitions (exposes a widl bug)

2005-05-26 Thread Alexandre Julliard
Mike McCormack <[EMAIL PROTECTED]> writes: > This patch demonstrates a problem with widl. This following > declaration fails to parse correctly, as "async" is detected as a > keyword, and disallowed as the name of a method in an interface. > > [propget, id(DISPID_XMLDOM_DOCUMENT_ASYNC)] > HRESUL