Aneurin Price wrote:
I've gone over this patch again, fixed any bugs I could find, and tried
to address the points made regarding readability. Hopefully the coding
style should now be much improved, so could anyone who knows about such
things give it a look over?
Well, it looks nicer, but it p
Hi Aneurin, some style comments on your patch:
+<<< file.c
+===
This shouldn't be in your patch.
+typedef struct
+{
+int flags;
+unsigned int width;
+__int64 precision;
+const MSVCRT_wchar_t *input;
+MSVCRT_wchar_t *output;
+int HeapAlloced;
+union
+{
+
I've gone over this patch again, fixed any bugs I could find, and tried
to address the points made regarding readability. Hopefully the coding
style should now be much improved, so could anyone who knows about such
things give it a look over? If there's not too much of a problem there
I'll fix
Mike Hearn wrote:
On Sat, 27 Nov 2004 20:37:21 +, Aneurin Price wrote:
Thanks for that; it's just the kind of comment I was looking for.
It wasn't a full patch as I wasn't planning to get it applied, and a
number of points were where I copied code from what was there already
:), but you even
On Sat, 27 Nov 2004 20:37:21 +, Aneurin Price wrote:
> So, I've had a go over this all, and here is a new version. Is it a step
> in the right direction? I still don't really know what I should be doing
> to improve this.
Yep, that's a lot better. There is still room for improvement
though:
Well I recently got re-motivated, by forgetting I was using an unpatched
version of Wine, and getting my WC3 campaign file nuked :(.
So, I've had a go over this all, and here is a new version. Is it a step
in the right direction? I still don't really know what I should be doing
to improve this.
On Thu, Nov 18, 2004 at 04:16:02PM +, Aneurin Price wrote:
> I don't really understand what it is you want, but I think I'm going to
> have to give up on this for the moment, until I get enough time to get
> more coding practice.
> Aneurin Price
If you don't mind, I will take up hacking it.
Alexandre Julliard wrote:
Aneurin Price <[EMAIL PROTECTED]> writes:
Any further comments on this?
Hard to say, that code is really painful to read. Please try to better
follow the coding conventions used in the rest of the code.
Apologies for long delay; I've been playing World of Warcraft for th
Aneurin Price <[EMAIL PROTECTED]> writes:
> Any further comments on this?
Hard to say, that code is really painful to read. Please try to better
follow the coding conventions used in the rest of the code.
--
Alexandre Julliard
[EMAIL PROTECTED]
Any further comments on this?
Aneurin Price <[EMAIL PROTECTED]> writes:
> Is there any particular reason this patch hasn't been committed?
> Something wrong or just overlooked?
You should implement the format strings in a way that the compiler
cannot check in order to avoid the warnings.
--
Alexandre Julliard
[EMAIL PROTECT
Is there any particular reason this patch hasn't been committed?
Something wrong or just overlooked?
12 matches
Mail list logo
