Re: MSVCRT: Re-implement *printf

2005-01-29 Thread Aneurin Price
Jesse Allen wrote: Sorry for being late at responding. I took a look at it finally like a week ago. You can definately break up the patch. Erm, nevermind on breaking it up yet. I started to myself, but I think it's more trouble than it's worth right now. We can have that done later if tha

Re: MSVCRT: Re-implement *printf

2005-01-29 Thread Jesse Allen
On Fri, 28 Jan 2005 18:18:40 -0700, Jesse Allen <[EMAIL PROTECTED]> wrote: > On Fri, 28 Jan 2005 12:48:12 +, Aneurin Price > > > > Nobody has any comments about this? > > > > > > Sorry for being late at responding. I took a look at it finally like > a week ago. You can definately break up t

Re: MSVCRT: Re-implement *printf

2005-01-28 Thread Jesse Allen
On Fri, 28 Jan 2005 12:48:12 +, Aneurin Price <[EMAIL PROTECTED]> wrote: > Changelog: > > > Re-implement all *printf functions in msvcrt.dll, according to > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt_format_specification_fields_.2d_.printf_and_wprintf_fu

Re: MSVCRT: Re-implement *printf

2005-01-28 Thread Juan Lang
Hi Aneurin, > Nobody has any comments about this? Well, I held off thinking I'd give Alexandre a chance to chime in. As it's a large patch, I knew it could take a while. But since he hasn't.. My advice isn't going to be as specific as it has been in the past. You've obviously done a lot on th

Re: MSVCRT: Re-implement *printf

2005-01-28 Thread Aneurin Price
Changelog: Re-implement all *printf functions in msvcrt.dll, according to http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt_format_specification_fields_.2d_.printf_and_wprintf_functions.asp and descriptions of appropriate functions. This should fix, among other thi

Re: MSVCRT: Re-implement *printf

2005-01-07 Thread Aneurin Price
Juan Lang wrote: Style point: (*pointer).whatever is written a bit more easily as pointer->whatever. That'd make your new patch a good bit more readable. --Juan __ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/

Re: MSVCRT: Re-implement *printf

2005-01-07 Thread Bill Medland
On January 7, 2005 09:04 am, Mike Hearn wrote: > On Fri, 07 Jan 2005 08:46:25 -0800, Juan Lang wrote: > > Style point: (*pointer).whatever is written a bit more easily as > > pointer->whatever. That'd make your new patch a good bit more readable. > > Are they even equivalent? My impression was th

Re: MSVCRT: Re-implement *printf

2005-01-07 Thread Mike Hearn
On Fri, 07 Jan 2005 08:46:25 -0800, Juan Lang wrote: > Style point: (*pointer).whatever is written a bit more easily as > pointer->whatever. That'd make your new patch a good bit more readable. Are they even equivalent? My impression was that (*pointer).whatever would make a temporary copy on th

Re: MSVCRT: Re-implement *printf

2005-01-07 Thread Juan Lang
Style point: (*pointer).whatever is written a bit more easily as pointer->whatever. That'd make your new patch a good bit more readable. --Juan __ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/