Re: MSI Patch Feedback

2009-01-09 Thread James Hawkins
On Fri, Jan 9, 2009 at 9:52 AM, ricardo filipe wrote: > > >>>"How should I attempt to test the changes I have made" >> I don't see testcases for any of these changes. Adding conformance >> tests would be the best first course of action: >> >> http://wiki.winehq.org/ConformanceTests >> http://wiki.

RE: MSI Patch Feedback

2009-01-09 Thread ricardo filipe
>>"How should I attempt to test the changes I have made" > I don't see testcases for any of these changes. Adding conformance > tests would be the best first course of action: > > http://wiki.winehq.org/ConformanceTests > http://wiki.winehq.org/WritingConformanceTests > > -- > -Austin > > he is

Re: MSI Patch Feedback

2009-01-09 Thread Austin English
On Fri, Jan 9, 2009 at 3:18 AM, Andrew Nguyen wrote: > Hello, > > I've written a few patches against dlls/msi/action.c in an effort to > rectify a difference in behavior with an MSI-based installer between > Windows and Wine with regard to environment variable processing. > Behavior not explicitly

MSI Patch Feedback

2009-01-09 Thread Andrew Nguyen
Hello, I've written a few patches against dlls/msi/action.c in an effort to rectify a difference in behavior with an MSI-based installer between Windows and Wine with regard to environment variable processing. Behavior not explicitly enumerated by MSDN is noted when a combination of the environmen