Re: Path for Testfiles (MSI: Test creating a package)

2005-09-06 Thread Mike McCormack
Detlef Riekenberg wrote: dlls/msi/tests : package.c ... i Suggest that: - all directories and files for tests should be created in "%TEMP%\winetest" - we modify "wine/tests.h" to get this path and check for path and name overflows (MAX_PATH and nesting level). "c:" could be readonl

Path for Testfiles (MSI: Test creating a package)

2005-09-06 Thread Detlef Riekenberg
Hi After reading reading this commit, > ChangeSet ID: 20009 > Added files: > dlls/msi/tests : package.c > Test creating a package. > Patch: http://cvs.winehq.org/patch.py?id=20009 ... i Suggest that: - all directories and files for tests should be created in "%TEMP%\winetes

Re: MSI: test creating a package

2005-09-06 Thread Andreas Mohr
Hi, On Tue, Sep 06, 2005 at 05:28:06PM +0900, Mike McCormack wrote: > > Andreas Mohr wrote: > > >Hmm, something seems to be missing here... > > The purpose of the test is only to prove that we can make a package. I > have other tests that I will submit later that build on > create_package_db

Re: MSI: test creating a package

2005-09-06 Thread Mike McCormack
Andreas Mohr wrote: Hmm, something seems to be missing here... The purpose of the test is only to prove that we can make a package. I have other tests that I will submit later that build on create_package_db and package_from_db, but this test does something useful as it is. Mike

Re: MSI: test creating a package

2005-09-06 Thread Andreas Mohr
Hi, On Tue, Sep 06, 2005 at 03:21:55PM +0900, Mike McCormack wrote: > ChangeLog: > <[EMAIL PROTECTED]> > <[EMAIL PROTECTED]> > * test creating a package +res = MsiCloseHandle( suminfo); +ok( res == ERROR_SUCCESS , "Failed to close suminfo" ); + + +res = MsiCloseHandle( hPackage); +