Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread James Hawkins
On Tue, Dec 16, 2008 at 11:59 AM, Aric Stewart wrote: > Ok, Though it mirrors what is happening over in MSI_RecordGetStringW so i > assumed it was just a few check that had been accidentally forgotten. > Yea, I'm sure it's right, but it's nice to verify those changes with tests and to keep it fr

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread James Hawkins
On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart wrote: > --- > dlls/msi/record.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > Can you add tests for this please? Thanks, James Hawkins

Re: MSI: fix some NULL checking in MSI_RecordGetStringA

2008-12-16 Thread Aric Stewart
Ok, Though it mirrors what is happening over in MSI_RecordGetStringW so i assumed it was just a few check that had been accidentally forgotten. -aric James Hawkins wrote: > On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart wrote: >> --- >> dlls/msi/record.c |7 --- >> 1 files changed, 4 i