Re: msi/tests: Use BOOL type where appropriate (resend)

2013-10-07 Thread Marvin
anoid android. === wvista (32 bit msi) === Timeout === w2008s64 (32 bit msi) === Timeout Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout

Re: msi/tests: Use BOOL type where appropriate

2013-10-07 Thread Marvin
anoid android. === wvista (32 bit msi) === The test timed out === w2008s64 (32 bit msi) === The test timed out === w7pro64 (32 bit msi) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout === w7pro64 (64 bit msi) === Timeout

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Alexandre Julliard
Christian Costa writes: > Le 08/05/2013 12:43, Alexandre Julliard a écrit : >> Christian Costa writes: >> >>> { >>> -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), >>> debugstr_w(lpCaption), >>> - uType, wLanguageId, f); >>> -return MessageBoxExW(hWnd,lpText,lpCap

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Christian Costa
Le 08/05/2013 12:43, Alexandre Julliard a écrit : Christian Costa writes: { -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), debugstr_w(lpCaption), - uType, wLanguageId, f); -return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); +FIXME("(%p, %s, %s,

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)

2013-05-08 Thread Alexandre Julliard
Christian Costa writes: > { > -FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), > debugstr_w(lpCaption), > - uType, wLanguageId, f); > -return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); > +FIXME("(%p, %s, %s, %u, 0x%08x, 0x%08x): semi-stub\n", hWnd,

Re: Re: msi/tests: Add a trailing '\n' to an ok() call.

2013-05-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25396 Your paranoid android

Re: msi/tests: Add a trailing '\n' to an ok() call.

2013-05-02 Thread Christian Costa
2013/5/2 Francois Gouget > --- > dlls/msi/tests/install.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c > index e5d996e..0c322be 100644 > --- a/dlls/msi/tests/install.c > +++ b/

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2013-05-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25385 Your paranoid android

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2013-05-01 Thread Christian Costa
Le 01/05/2013 14:34, Hans Leidekker a écrit : On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: diff --git a/dlls/msi/media.c b/dlls/msi/media.c index 612624d..4145c76 100644 --- a/dlls/msi/media.c +++ b/dlls/msi/media.c @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2013-05-01 Thread Hans Leidekker
On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..4145c76 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE > fd

Re: msi: Don't ignore failure to remove an existing product.

2013-02-18 Thread Alexandre Julliard
Hans Leidekker writes: > --- > dlls/msi/action.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) It fails here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok action.c:6397: Test failed: Expected ERR

Re: MSI signing

2013-02-15 Thread Marc-André Lureau
Good news! Thanks to Per Allansson, author of osslsigncode, we know now that 98C090F33284468D64F30EE7B8C00894135D54C8 is sha1 of Root Entry unique identifier 84 10 0c 00 00 00 00 00 c0 00 00 00 00 00 00 46. -- Marc-André Lureau

MSI signing

2013-02-15 Thread Marc-André Lureau
Hello! PE signing is already publicly documented by Microsoft, and we have an open-source tool (osslsigncode) capable of signing PE and Cabinet. A signed MSI dump easily reveals that the signature is under the '\005DigitalSignature' stream, and it's a regular pkcs#7 signature, who

Re: msi/tests: Move a couple of tests from install.c to msi.c.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24381 Your paranoid android

Re: [3/3] msi: Improve parsing of the supported platforms string.

2013-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24227 Your paranoid android

Re: msi: Fix logical expressions that always evaluate to FALSE

2012-12-10 Thread Hans Leidekker
On Sat, 2012-12-08 at 21:59 +, Andrew Talbot wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 076d1b3..677a43f 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -6763,7 +6763,7 @@ static UINT ACTION_RemoveODBC( MSIPACKAGE *package ) > #def

Re: msi: Fix a couple of leaks (coverity)

2012-11-16 Thread Hans Leidekker
On Fri, 2012-11-16 at 11:50 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 11913ef..98d7513 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package) > if (r

Re: msi: Fix some leaks (coverity)

2012-11-07 Thread Hans Leidekker
On Thu, 2012-11-08 at 01:32 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index f9ab550..8a6c952 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -5809,7 +5809,16 @@ static UINT ITERATE_InstallService(MSIRECORD *rec,

Re: msi: Fix some leaks (coverity)

2012-11-06 Thread Alexandre Julliard
Frédéric Delanoy writes: > @@ -151,15 +151,23 @@ static UINT propvar_changetype(PROPVARIANT *changed, > PROPVARIANT *property, VART > { > HRESULT hr; > HMODULE propsys = LoadLibraryA("propsys.dll"); > + > +if (!propsys) > +{ > +ERR("Failed to load propsys.dll: %u\n", G

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2012-09-29 Thread Christian Costa
Le 28/09/2012 09:05, Hans Leidekker a écrit : On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote: if (!(cabinet_file = get_cabinet_filename(mi))) The requirement that the continuous cabinet name matches the next cabinet in the media table might simply be too strict. Perhaps we nee

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2012-09-28 Thread Hans Leidekker
On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote: > >> if (!(cabinet_file = get_cabinet_filename(mi))) > > The requirement that the continuous cabinet name matches the next cabinet > > in the media table > > might simply be too strict. Perhaps we need to try them one by one and let

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2012-09-27 Thread Christian Costa
Le 27/09/2012 11:26, Hans Leidekker a écrit : On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: diff --git a/dlls/msi/media.c b/dlls/msi/media.c index 612624d..8a39fcd 100644 --- a/dlls/msi/media.c +++ b/dlls/msi/media.c @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2012-09-27 Thread Hans Leidekker
On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..8a39fcd 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE > fd

Re: [2/2] msi: Try the registered install location first when resolving the target directory.

2012-07-31 Thread Alexandre Julliard
Hans Leidekker writes: > --- > dlls/msi/action.c | 18 +++--- > dlls/msi/msipriv.h |1 + > 2 files changed, 16 insertions(+), 3 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so ../../..

Re: [PATCH] msi/tests: Use always static binding for GetTokenInformation

2012-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20375 Your paranoid android

Re: msi/tests: Mark some test results as broken.

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20071 Your paranoid android

SV: msi: fix incorrect decoding of msi stream-names

2012-07-15 Thread Oleg Jakobsen
Til: wine-devel@winehq.org; Oleg Jakobsen Emne: Re: msi: fix incorrect decoding of msi stream-names On Wed, 2012-07-11 at 15:03 +, Oleg Jakobsen wrote: > @@ -203,6 +203,7 @@ BOOL decode_streamname(LPCWSTR in, LPWSTR out) > *out++ = mime2utf(ch&0x3f); >

Re: msi: fix incorrect decoding of msi stream-names

2012-07-12 Thread Hans Leidekker
On Wed, 2012-07-11 at 15:03 +, Oleg Jakobsen wrote: > @@ -203,6 +203,7 @@ BOOL decode_streamname(LPCWSTR in, LPWSTR out) > *out++ = mime2utf(ch&0x3f); > count++; > ch = mime2utf((ch>>6)&0x3f); > + continue; >

Re: msi: fix incorrect decoding of msi stream-names

2012-07-11 Thread Nikolay Sivov
On 7/11/2012 18:03, Oleg Jakobsen wrote: Looked at how you decode msi-stream names, and spotted a minor error whith the decoding. regards Oleg Why do you think it's an error? Looks like in this case it decodes one input WCHAR to two output WCHARs in a single pass.

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.

2012-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android

Re: [1/4] msi: Add support for 64-bit registry components. (resend)

2012-06-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android

Re: [1/5] msi: Add support for 64-bit registry components.

2012-06-05 Thread Jacek Caban
On 6/5/12 8:48 PM, Hans Leidekker wrote: On Tue, 2012-06-05 at 20:35 +0200, Alexandre Julliard wrote: Hans Leidekker writes: --- dlls/msi/action.c| 30 +++--- dlls/msi/msi_main.c |1 + dlls/msi/msipriv.h |1 + dlls/msi/package.c |2 - dlls/msi

Re: [1/5] msi: Add support for 64-bit registry components.

2012-06-05 Thread Hans Leidekker
On Tue, 2012-06-05 at 20:35 +0200, Alexandre Julliard wrote: > Hans Leidekker writes: > > > --- > > dlls/msi/action.c| 30 +++++++--- > > dlls/msi/msi_main.c |1 + > > dlls/msi/msipriv.h |1 + > > dlls/msi/package.c |

Re: [1/5] msi: Add support for 64-bit registry components.

2012-06-05 Thread Alexandre Julliard
Hans Leidekker writes: > --- > dlls/msi/action.c| 30 +++--- > dlls/msi/msi_main.c |1 + > dlls/msi/msipriv.h |1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 > ++ &g

Re: [4/5] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.

2012-06-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18792 Your paranoid android

Re: [1/5] msi: Add support for 64-bit registry components.

2012-06-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18791 Your paranoid android

Re: msi: Tweak msiexec's usage message.

2012-05-07 Thread Francois Gouget
On Sat, 5 May 2012, Frédéric Delanoy wrote: [...] > The msiexec conventions look sane to me: [ ] for optional and { } for > mandatory parameters (*only* when a choice/list is involved). It's > also what's used in other wine commands "/?" results (e.g. 'start', > 'ipconfig', 'regedit', etc.). It's

Re: msi: Tweak msiexec's usage message.

2012-05-05 Thread Frédéric Delanoy
On Fri, May 4, 2012 at 3:21 PM, Francois Gouget wrote: > On Fri, 4 May 2012, Julian Rüger wrote: > >> Hi Francois and wine-devel, >> >> while we're at it, shouldn't these >> >> >"Advertise a product:\n" >> >"\t/j[u|m] package [/t transform] [/g languageid]\n" >> >"Apply a patch:\n" >> >"\t/p patch

Re: msi: Tweak msiexec's usage message.

2012-05-04 Thread Francois Gouget
On Fri, 4 May 2012, Julian Rüger wrote: > Hi Francois and wine-devel, > > while we're at it, shouldn't these > > >"Advertise a product:\n" > >"\t/j[u|m] package [/t transform] [/g languageid]\n" > >"Apply a patch:\n" > >"\t/p patch_package [property]\n" > >"\t/p patch_package /a package [propert

Re: msi: Tweak msiexec's usage message.

2012-05-04 Thread Julian Rüger
Hi Francois and wine-devel, while we're at it, shouldn't these >"Advertise a product:\n" >"\t/j[u|m] package [/t transform] [/g languageid]\n" >"Apply a patch:\n" >"\t/p patch_package [property]\n" >"\t/p patch_package /a package [property]\n" also be put in curly brackets? Like this: \t/j[u|m

Re: msi: fixed MsiGetFileHashW for empty files (try 2)

2012-04-04 Thread Alexandre Julliard
Robert van Herk writes: > @@ -493,6 +493,45 @@ static void test_MsiGetFileHash(void) > } > } > > +static void test_MsiGetFileHashForEmptyFile(void) { > +char path[MAX_PATH]; > +MSIFILEHASHINFO hi; > +char file[MAX_PATH]; > +UINT res; > + > +/* Create empty te

Re: msi: add support for MSIRUNMODE_REBOOTNOW in MsiGetMode

2012-03-31 Thread Austin English
On Sat, Mar 31, 2012 at 06:00, Hans Leidekker wrote: > On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote: >> +    case MSIRUNMODE_REBOOTNOW: >> +        r = package->need_reboot; >> +        break; >> + > > MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing. > > It seems

Re: msi: add support for MSIRUNMODE_REBOOTNOW in MsiGetMode

2012-03-31 Thread Hans Leidekker
On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote: > +case MSIRUNMODE_REBOOTNOW: > +r = package->need_reboot; > +break; > + MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing.

Re: msi: Implement MSIMODIFY_MERGE function in TABLE_modify.

2012-03-26 Thread Andoni Morales
one. The primary key 2 is used later in the test and changing it to a value that's not used later is enough. The diff with the respect of the previous patch is: diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index f5a3c1e..4c91bd8 100644 --- a/dlls/msi/tests/db.c +++ b/dl

Re: msi: Implement MSIMODIFY_MERGE function in TABLE_modify.

2012-03-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17479 Your paranoid android

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).

2012-02-03 Thread Juan Lang
Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); -if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; -SysFreeString(s); +if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; +SysFreeString( s ); Is it real

Re: [2/2] msi/tests: Try harder to remove a shortcut file.

2011-12-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15780 Your paranoid android

Re: [1/2] Revert "msi: Use MsgWaitForMultipleObjectsEx to do waits."

2011-11-09 Thread Alexandre Julliard
Hans Leidekker writes: > This reverts commit 2556173f20ba9583044aaf31b16cbb2214d2b907. > It causes a regression in the Quicken 2011 installer. Does it really break because we are processing messages, or just because we don't wait properly? If so fixing the wait would seem a better choice. --

Re: [msi] initialize variable to placate static analyzers

2011-10-13 Thread Michael Stefaniuc
Hello Dan, Dan Kegel wrote: > Avoids the spurious compiler warning > > msi.c: In function 'MSI_ApplyPatchW': > msi.c:353:10: error: 'r' may be used uninitialized in this function > > Hans says "It's compiler confusion but I'm fine with a patch that initializes > r with ERROR_FUNCTION_FAILED." wh

Re: [PATCH 1/7] msi/custom.c: unify thread handling of different custom action types (resend)

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 2:29 PM, Hans Leidekker wrote: > On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote: > +static HRESULT get_action_info( msi_custom_action_info *info, INT *type, > +                                BSTR *source, BSTR *target, BSTR *name, > +                              

Re: [PATCH 5/7] msi/custom.c: get rid of MSIRUNNINGACTION

2011-10-11 Thread Bernhard Loos
On Tue, Oct 11, 2011 at 3:22 PM, Hans Leidekker wrote: > >> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, >> +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package, >> LPCWSTR source, >>                                  LPCWSTR target, const INT type, LPCW

Re: [PATCH 5/7] msi/custom.c: get rid of MSIRUNNINGACTION

2011-10-11 Thread Hans Leidekker
> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source, > +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package, > LPCWSTR source, > LPCWSTR target, const INT type, LPCWSTR > action) > { > WCHAR *exe, *arg; > msi_custo

Re: [PATCH 1/7] msi/custom.c: unify thread handling of different custom action types (resend)

2011-10-11 Thread Hans Leidekker
On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote: +static HRESULT get_action_info( msi_custom_action_info *info, INT *type, +BSTR *source, BSTR *target, BSTR *name, +IWineMsiRemotePackage **package ) { -IClassFactory *cf = N

Re: msi/tests: Properly preserve pending file renames.

2011-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14578 Your paranoid android

Re: msi/tests: Avoid #if 0 to make sure code still compiles.

2011-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14533 Your paranoid android

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-20 Thread Hans Leidekker
On Tue, 2011-09-20 at 10:51 +0200, Michael Stefaniuc wrote: > Hans Leidekker wrote: > > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, > >> LPCSTR szFolder, > >> awstring str; > >> UINT r; > >> > >

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-20 Thread Michael Stefaniuc
Hans Leidekker wrote: > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, >> LPCSTR szFolder, >> awstring str; >> UINT r; >> >> -TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), >>

Re: msi: Print the string and not the pointer in a TRACE.

2011-09-19 Thread Hans Leidekker
On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR > szFolder, > awstring str; > UINT r; > > -TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), > pcchPathBuf); > +TRACE("%s

Re: msi: Improve parsing of the package platform.

2011-09-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14255 Your paranoid android

re: msi: Properly check for a specified flag combination

2011-09-10 Thread Dan Kegel
d 90%CPU (0avgtext+0avgdata 51216maxresident)k 0inputs+7360outputs (0major+17117minor)pagefaults 0swaps make: *** [action.ok] Error 7 -- Forwarded message -- From: Date: Sat, Sep 10, 2011 at 12:33 PM Subject: Re: 78647: Subject: msi: Properly check for a specified flag combination

Re: [2/8] msi/test: Mark some test results as broken.

2011-09-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14087 Your paranoid android

Re: [2/4] msi/tests: Fix a number of test messages.

2011-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android

Re: [PATCH 2/4] msi: reorder tables to optimize condition evaluation

2011-08-31 Thread Dan Kegel
ss 0x407537e9 (thread 002c), starting debugger... Backtrace: =>0 WHERE_execute+0x17a(view=0x11fe58, record=(nil)) [dlls/msi/where.c:821] 1 SELECT_execute+0x9d(view=0x138408, record=(nil)) [dlls/msi/select.c:181] 2 MSI_ViewExecute+0xb4(query=0x11fce0, rec=(nil)) [dlls/msi/msiquery.c:457] 3 get_

Re: [PATCH 1/4] msi: speed up WHERE statement evaluation by evaluating the condition as early as possible

2011-08-31 Thread Alexandre Julliard
Bernhard Loos writes: > @@ -639,6 +715,8 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, > MSIRECORD *record ) > while ((table = table->next)); > > rows = msi_alloc( wv->table_count * sizeof(*rows) ); > +memset( rows, 0xFF, sizeof( rows ) ); > + If the goal is to set them

Re: [PATCH 2/8] msi: make WHEREVIEW able to deal directly with multiple tables

2011-08-25 Thread Alexandre Julliard
Bernhard Loos writes: > +/* below is the query interface to a table */ > + > typedef struct tagMSIROWENTRY > { > -UINT value; > +UINT values[0]; Zero-size arrays are not portable. -- Alexandre Julliard julli...@winehq.org

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, Francois Gouget wrote: [...] > From my understanding, in this case using a simple skip() means that > anyone running WineTest on Windows in a non-administrator account will > get a test failure. Since we don't seem to have a policy mandating that > WineTest be run in an admi

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, GOUJON Alexandre wrote: > On 08/24/2011 10:47 AM, Hans Leidekker wrote: > > No, win_skip is for behavior observed on Windows that Wine should not > > emulate, which is not the case here. > Is there any page on the wiki explaining the meaning of broken(), skip(), > win_skip() ?

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Hans Leidekker
On Wed, 2011-08-24 at 15:11 +0200, Francois Gouget wrote: > From my understanding, in this case using a simple skip() means that > anyone running WineTest on Windows in a non-administrator account will > get a test failure. Since we don't seem to have a policy mandating that Quite the opposite

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread GOUJON Alexandre
On 08/24/2011 10:47 AM, Hans Leidekker wrote: No, win_skip is for behavior observed on Windows that Wine should not emulate, which is not the case here. Is there any page on the wiki explaining the meaning of broken(), skip(), win_skip() ? Because your definition of win_skip is my definition of

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Francois Gouget
On Wed, 24 Aug 2011, Hans Leidekker wrote: > On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote: > > > Shouldn't that be a win_skip()? Wine always runs as administrator, and > > if the process is running as a limited user, something may be broken? > > Unless you're preparing for when wine su

Re: [PATCH 1/8] msi: use an array instead of a hashtable for WHEREVIEW

2011-08-24 Thread Alexandre Julliard
Bernhard Loos writes: > +static UINT add_row(MSIWHEREVIEW *wv, UINT val) > { > -MSIHASHENTRY *new = msi_alloc(sizeof(MSIHASHENTRY)); > -MSIHASHENTRY *prev; > +MSIROWENTRY *new; > + > +if (wv->reorder_size <= wv->row_count) > +{ > +MSIROWENTRY **new_reorder; > +

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Hans Leidekker
On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote: > Shouldn't that be a win_skip()? Wine always runs as administrator, and > if the process is running as a limited user, something may be broken? > Unless you're preparing for when wine supports non-admin mode.. :) No, win_skip is for behavi

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread Austin English
On Wed, Aug 24, 2011 at 03:22, Hans Leidekker wrote: > --- >  dlls/msi/tests/action.c |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c > index aac601f..90832af 100644 > --- a/dlls/msi/tests/

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)

2011-08-23 Thread Octavian Voicu
On Tue, Aug 23, 2011 at 3:13 PM, Joris Huizer wrote: > On 08/23/2011 11:45 AM, Hans Leidekker wrote: > >> +if (!strcmpiW( package, unsquashed )) >> > > I'm confused about the last part of the function. > I think if the comparison between 'package' and 'unsquashed' fails, you > want to return a

Re: [7/7] msi/tests: Clean up local packages.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13580 Your paranoid android

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)

2011-08-23 Thread Joris Huizer
Just an implementation detail I noticed: On 08/23/2011 11:45 AM, Hans Leidekker wrote: + +static UINT get_registered_local_package( const WCHAR *product, const WCHAR *package, WCHAR *localfile ) +{ +MSIINSTALLCONTEXT context; +HKEY product_key, props_key; +WCHAR *registered_package

Re: [6/7] msi: Remove icons when the product is uninstalled.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13579 Your paranoid android

Re: [7/7] msi/tests: Clean up local packages.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13576 Your paranoid android

Re: [6/7] msi: Remove icons when the product is uninstalled.

2011-08-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13575 Your paranoid android

Re: [3/5] msi: Don't create a temporary copy of the package.

2011-07-25 Thread Alexandre Julliard
Hans Leidekker writes: > There's no need for it now that we open the package in transacted mode. This breaks the Gecko install: fixme:msi:MSI_OpenDatabaseW open failed r = 80030005 for L"Z:\\home\\julliard\\wine\\wine\\..\\gecko\\wine_gecko-1.2.0-x86.msi" err:appw

Re: [3/8] msi: Handle escaped double quotes in command line parsing.

2011-06-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12111 Your paranoid android

Re: [2/5] msi: Pass the full custom action command to CreateProcess.

2011-06-10 Thread Alexandre Julliard
Hans Leidekker writes: > @@ -772,10 +772,22 @@ static HANDLE execute_command( const WCHAR *exe, WCHAR > *arg, const WCHAR *dir ) > { > STARTUPINFOW si; > PROCESS_INFORMATION info; > +int len; > +WCHAR *cmd; > BOOL ret; > > +len = strlenW( exe ); > +if (arg) len

Re: [5/5] msi: Implement and test MsiSetFeatureAttributes.

2011-06-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11595 Your paranoid android

Re: [4/5] msi: Implement and test MsiGetFeatureInfo.

2011-06-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11594 Your paranoid android

re: Hans Leidekker : msi: Support rollback of failed uninstalls.

2011-05-25 Thread Hans Leidekker
On Wed, 2011-05-25 at 18:49 +, Dan Kegel wrote: > wow, msi has really come a long way! Thanks. In hindsight we should have implemented rollbacks early on, when installers still failed regularly ;-)

re: Hans Leidekker : msi: Support rollback of failed uninstalls.

2011-05-25 Thread Dan Kegel
wow, msi has really come a long way!

Re: [PATCH] msi: Fixed check_flag_combo macro (Coverity)

2011-05-09 Thread Hans Leidekker
On Mon, 2011-05-09 at 13:05 +0200, Marcus Meissner wrote: > > It doesn't work here: > > > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so > > action.c && touch action.ok > > action.c:5578: Test failed: Expected ERROR_SUCCESS, got 1627 > > action.c:5587: Test failed:

Re: [PATCH] msi: Fixed check_flag_combo macro (Coverity)

2011-05-09 Thread Marcus Meissner
On Mon, May 09, 2011 at 12:07:39PM +0200, Alexandre Julliard wrote: > Marcus Meissner writes: > > > The macro was always FALSE, as > > x & y == ~y > > is always FALSE. x& y == y was clearly intended. > > CID 1448 > > It doesn't work here: > > ../../../tools/runtest -q -P wine -M msi.dll -T

Re: [PATCH] msi: Fixed check_flag_combo macro (Coverity)

2011-05-09 Thread Alexandre Julliard
Marcus Meissner writes: > The macro was always FALSE, as > x & y == ~y > is always FALSE. x& y == y was clearly intended. > CID 1448 It doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok action.c:5578: Test failed: E

Re: msi: Fix parsing of an empty property followed by a non-empty property.

2011-04-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10333 Your paranoid android

Re: [06/10] msi: Accept whitespace-only property values on the command line.

2011-03-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10214 Your paranoid android

Re: [02/10] msi/tests: Get rid of workarounds for win9x test failures.

2011-03-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10212 Your paranoid android

Re: [01/10] msi: Ignore invalid upgrade codes in the PublishProduct action.

2011-03-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10211 Your paranoid android

Re: msi: Add an offset to sequence numbers belonging to files added by a patch. (try 2)

2011-03-21 Thread Hans Leidekker
On Mon, 2011-03-21 at 14:14 +0100, David Hedberg wrote: > +static void msi_patch_offset_list_init(struct msi_patch_offset_list **pos) > +{ > +*pos = msi_alloc(sizeof(struct msi_patch_offset_list)); > +list_init( &(*pos)->files ); > +(*pos)->count = (*pos)->max = 0; > +(*pos)->min =

Re: [PATCH 3/3] msi: Add an offset to sequence numbers belonging to files added by a patch.

2011-03-10 Thread Hans Leidekker
On Thu, 2011-03-10 at 02:20 +0100, David Hedberg wrote: > +static UINT msi_set_patch_offsets(MSIPACKAGE *package) > +{ > +static const WCHAR query_media[] = { > +'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' > ','M','e','d','i','a',' ', > +'W','H','E','R','E',' ','S','

Re: [3/3] msi: Assume a file is present if the target exists with the same size and there's no file version or hash to verif

2011-03-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9778 Your paranoid android.

Re: [2/3] msi: Load media info even if there's no file to install.

2011-03-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9777 Your paranoid android.

Re: [5/5] msi: Manage one assembly cache per major version of the .NET runtime.

2011-03-07 Thread Hans Leidekker
On Mon, 2011-03-07 at 08:57 -0600, Vincent Povirk wrote: > > +static const WCHAR szVersion11[] = > > {'v','1','.','1','.','4','3','2','2',0}; > > +static const WCHAR szVersion20[] = > > {'v','2','.','0','.','5','0','7','2','7',0}; > > No v4.0.30319 ? Not yet. It doesn't install so I can

Re: [5/5] msi: Manage one assembly cache per major version of the .NET runtime.

2011-03-07 Thread Vincent Povirk
> +    static const WCHAR szVersion11[] = > {'v','1','.','1','.','4','3','2','2',0}; > +    static const WCHAR szVersion20[] = > {'v','2','.','0','.','5','0','7','2','7',0}; No v4.0.30319 ?

Re: [1/5] msi/tests: Check the result of get_system_dirs and get_user_dirs.

2011-03-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9724 Your paranoid android.

  1   2   3   4   5   6   7   8   9   10   >