Re: MSHMTL: Added QueryStatus implementation

2005-08-16 Thread Jacek Caban
Saulius Krasuckas wrote: * On Mon, 15 Aug 2005, Jacek Caban wrote: I've tried to get other tests working on win 98, without success. It's possible that it won't work this way on 9x, It seems I've found one bug in test/htmldoc.c: |if(activeobj) { | - IOleInPlaceActiveObject

Re: MSHMTL: Added QueryStatus implementation

2005-08-16 Thread Saulius Krasuckas
* On Mon, 15 Aug 2005, Jacek Caban wrote: > > I've tried to get other tests working on win 98, > without success. It's possible that it won't work this > way on 9x, It seems I've found one bug in test/htmldoc.c: |if(activeobj) { | - IOleInPlaceActiveObject_GetWindow(activeobj, &hwnd)

Re: MSHMTL: Added QueryStatus implementation

2005-08-15 Thread Jacek Caban
Saulius Krasuckas wrote: * On Sun, 14 Aug 2005, Jacek Caban wrote: * Saulius Krasuckas wrote: Is something like this OK? I have "borrowed" boolean variable expect_SetActiveObject_active. Yes, it looks good. Does that mean by a chance it can to wine-patches? :-) Hell

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Jacek Caban wrote: > * Saulius Krasuckas wrote: > > > > Is something like this OK? I have "borrowed" boolean variable > > expect_SetActiveObject_active. > > Yes, it looks good. Does that mean by a chance it can to wine-patches? :-)

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Jacek Caban
Saulius Krasuckas wrote: * On Sun, 14 Aug 2005, Jacek Caban wrote: I'm not sure if it is a correct fix. Although it avoids crashes, much less functionality of QueryStatus is tested. Before your patch all possible commands were tested. This is true only for nt family windows. :-P On

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Saulius Krasuckas wrote: > * On Sun, 14 Aug 2005, Jacek Caban wrote: > > > > Presently if you want to make this test not to crash, you may disable > > IOleCommand tests if UIActivate fails. Is something like this OK? I have "borrowed" boolean variable expect_SetActiveObj

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Jacek Caban wrote: > > I'm not sure if it is a correct fix. Although it avoids crashes, > much less functionality of QueryStatus is tested. Before > your patch all possible commands were tested. This is true only for nt family windows. :-P On 9x test function exits on an

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Jacek Caban
Hello. Saulius Krasuckas wrote: * On Tue, 2 Aug 2005, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c 26 Jul 2005 10:31:23 - 1.5 +++ dlls/mshtml/tests/htmldoc.c 1 Aug 2005 22:33:37 - @@ -806,12 +806,76 @@ static void test_Persist() } } +static OLECMDF expect_cmds[OLECMD

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Sun, 14 Aug 2005, Saulius Krasuckas wrote: > * On Tue, 2 Aug 2005, Jacek Caban wrote: > > > > +hres = IOleCommandTarget_QueryStatus(cmdtrg, NULL, 0, NULL, NULL); > > +ok(hres == S_OK, "QueryStatus failed: %08lx\n", hres); > > + > > +hres = IOleCommandTarget_QuerySt

Re: MSHMTL: Added QueryStatus implementation

2005-08-14 Thread Saulius Krasuckas
* On Tue, 2 Aug 2005, Jacek Caban wrote: > > --- dlls/mshtml/tests/htmldoc.c 26 Jul 2005 10:31:23 - 1.5 > +++ dlls/mshtml/tests/htmldoc.c 1 Aug 2005 22:33:37 - > @@ -806,12 +806,76 @@ static void test_Persist() > } > } > > +static OLECMDF expect_cmds[OLECMDID_GETPRINTTEMPLATE+