Re: Listview notify_dispinfoT Messageformat

2004-11-01 Thread Thorsten Kani
I asked the List about the Problem and how to solve it correctly. Please excuse my bad English (: - will try your patch asap. Tho Why are you saying that. The code treats LVN_GETDISPINFOW special because it's the only type of message that *gets* textual data rather then sending. SO for this reason

Re: Listview notify_dispinfoT Messageformat

2004-10-31 Thread Dimitrie O. Paun
On Mon, Nov 01, 2004 at 01:43:44AM +0100, Thorsten Kani wrote: > As i understand it, the old Listview code was assuming that > LVN_GETDISPINFOW is never used and tried to convince apps with the > "A" version of the Message.. Why are you saying that. The code treats LVN_GETDISPINFOW special b

Re: Listview notify_dispinfoT Messageformat

2004-10-31 Thread Thorsten Kani
Oh, come on, it was just a few more lines of code. In fact, I was happy with the code as it standed (that's no surprise, as I wrote it :)). I think we should just revert to it, and accept changes only with supporting tests. At the time that Aric submitted the patch, I was rather unhappy with it, b

Re: Listview notify_dispinfoT Messageformat

2004-10-31 Thread Dimitrie O. Paun
On Sun, Oct 31, 2004 at 10:50:33AM +, Robert Shearman wrote: > Yes, that is correct. It would be a lot better to use a boolean flag > rather than storing the actual format code so that: > if (infoPtr->notifyFormat == NFR_UNICODE) > becomes: > if (infoPtr->bUnicode) Maybe a bit simpler yes, bu

Re: Listview notify_dispinfoT Messageformat

2004-10-31 Thread Robert Shearman
Dimitrie O. Paun wrote: On Wed, Oct 27, 2004 at 09:28:33PM +0100, Robert Shearman wrote: To summarise: *all* common control notifications should be sent in the same format (ANSI/Unicode) as their parent (except if overriden by the CCS_SETUNICODEFORMAT message). It should not be based on the me

Re: Listview notify_dispinfoT Messageformat

2004-10-30 Thread Dimitrie O. Paun
On Wed, Oct 27, 2004 at 09:28:33PM +0100, Robert Shearman wrote: > To summarise: *all* common control notifications should be sent in the > same format (ANSI/Unicode) as their parent (except if overriden by the > CCS_SETUNICODEFORMAT message). It should not be based on the message > sent to the

Re: Listview notify_dispinfoT Messageformat

2004-10-28 Thread Thorsten Kani
Testing out your more general solution introduced no Problems with the Listview on my Testsystem. If the Patch gets applied, i will modify the callers of notify_dispinfo to respect that "isW" isnt longer used. Tho Robert Shearman wrote: Thorsten Kani wrote: Hello, Testing showed that the curre

Re: Listview notify_dispinfoT Messageformat

2004-10-27 Thread Robert Shearman
Thorsten Kani wrote: Hello, Testing showed that the current implementation of notify_dispinfoT doesnt work with W2K. (or at least not with SP4 (: ) The attached patch corrects that our Listview doesnt display anything on native. Following assumption proved to be wrong for the Message LVN_GETDI

Listview notify_dispinfoT Messageformat

2004-10-27 Thread Thorsten Kani
Hello, Testing showed that the current implementation of notify_dispinfoT doesnt work with W2K. (or at least not with SP4 (: ) The attached patch corrects that our Listview doesnt display anything on native. Following assumption proved to be wrong for the Message LVN_GETDISPINFOW: /* With test