Re: Listbox fixes

2004-09-26 Thread Shachar Shemesh
Alexandre Julliard wrote: Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too. Thing is, they don't run for me. On a clean CVS checkout after compile, I get: wine$ make test make[1]: Entering directory `/home/sun/sou

Re: Listbox fixes

2004-09-26 Thread Shachar Shemesh
Alexandre Julliard wrote: Yes it happens regularly, maybe once or twice a month. And yes, it would be a good idea for other developers to run the tests too. Thing is, they don't run for me. On a clean CVS checkout after compile, I get: wine$ make test make[1]: Entering directory `/home/sun/sou

Re: Listbox fixes

2004-09-24 Thread Alexandre Julliard
Hans Leidekker <[EMAIL PROTECTED]> writes: > Wow, is this what I think it is? I mean, did our test harness > show it's protential here to detect regressions at check-in time? > > Does that happen often? Should Wine developers start running the > tests before submitting a patch? Yes it happens reg

Re: Listbox fixes

2004-09-24 Thread Jon Griffiths
> Does that happen often? Should Wine developers start running the > tests before submitting a patch? Absolutely, my bad. I didn't actually realise they were any listbox tests! Updated patch coming. Jon = "Don't wait for the seas to part, or messiahs to come; Don't you sit around and was

Re: Listbox fixes

2004-09-24 Thread Hans Leidekker
On Friday 24 September 2004 03:13, Alexandre Julliard wrote: > >+dlls/user/listbox.c > > Draw background of the empty selected item in empty lists > > Dont draw a focus rect if we do not have the focus > > Dont select items on key up/down in multi-select lists > > This is causing

Re: Listbox fixes

2004-09-23 Thread Alexandre Julliard
Jon Griffiths <[EMAIL PROTECTED]> writes: >+dlls/user/listbox.c > Draw background of the empty selected item in empty lists > Dont draw a focus rect if we do not have the focus > Dont select items on key up/down in multi-select lists This is causing a test failure: listbox.c:134: