Re: League of Legends patches

2012-07-04 Thread Andrea Canciani
On Tue, Jul 3, 2012 at 3:45 PM, Dan Kegel wrote: > On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani wrote: >> I tried to follow the http://wiki.winehq.org/SubmittingPatches >> guidelines, but this is my first submission to wine, so I guess the >> patches might need further improvement. >> Please p

Re: League of Legends patches

2012-07-04 Thread Jonas Maebe
Dan Kegel wrote on Wed, 04 Jul 2012: (https://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests_blacklist.txt has a list of all the tests that the buildbot failed on while it was running The ones annotated with http://xquartz.macosforge.org/trac/ticket/512 should work with the

Re: League of Legends patches

2012-07-04 Thread Dan Kegel
On Wed, Jul 4, 2012 at 12:15 AM, Andrea Canciani wrote: >> Do you think you could write a test that (semi-)reliably >> causes the deadlock you're fixing? > > Yes, I guess it should be possible. > Could you point me to a test which triggers a deadlock (in particular, > how should the deadlock be ha

Re: League of Legends patches

2012-07-03 Thread Dan Kegel
On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani wrote: > I tried to follow the http://wiki.winehq.org/SubmittingPatches > guidelines, but this is my first submission to wine, so I guess the > patches might need further improvement. > Please point out any issues that need fixing. On an administriv