Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Reece Dunn
2009/4/20 Detlef Riekenberg : > On Mo, 2009-04-20 at 10:01 +0200, Henri Verbeet wrote: >> More specifically, you need to protect this with an #ifdef. > >> #ifdef __GNUC__ >> #define __WINE_ATTR_UNUSED __attribute__((unused)) >> #else >> #define __WINE_ATTR_UNUSED >> #endif > > Support for compiler

Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Henri Verbeet
2009/4/20 Detlef Riekenberg : > Support for compiler specific features should be tested during > configure. > What would that look like, approximately?

Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 10:01 +0200, Henri Verbeet wrote: > More specifically, you need to protect this with an #ifdef. > #ifdef __GNUC__ > #define __WINE_ATTR_UNUSED __attribute__((unused)) > #else > #define __WINE_ATTR_UNUSED > #endif Support for compiler specific features should be tested during

Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Henri Verbeet
2009/4/20 James McKenzie : > What compiler was complaining about the static inline problem?  Your > solution may cause problems with other compilers. > More specifically, you need to protect this with an #ifdef. E.g.: #ifdef __GNUC__ #define __WINE_ATTR_UNUSED __attribute__((unused)) #else #defin

Re: Janitor: list.h functions defined but not used

2009-04-19 Thread James McKenzie
Glenn L. McGrath wrote: > Hi all, im new to the list, im interested in grinding away at some of > the warnings wine generates... > > make depend was complaining about some static inline functions that it > thinks arent used, this patch uses __attribute__ ((used)) to disable the > warning. > > > Gl

Re: Janitor: list.h functions defined but not used

2009-04-19 Thread Jeremy White
Glenn L. McGrath wrote: > Hi all, im new to the list, im interested in grinding away at some of > the warnings wine generates... Welcome to Wine, and thanks! Be cautioned that open source projects can be brutal and mean places. I think Wine is one of the nicer ones, but that mostly means that ou

Re: Janitor: list.h functions defined but not used

2009-04-19 Thread Austin English
On Sun, Apr 19, 2009 at 8:00 PM, Glenn L. McGrath wrote: > Hi all, im new to the list, im interested in grinding away at some of > the warnings wine generates... > > make depend was complaining about some static inline functions that it > thinks arent used, this patch uses __attribute__ ((used)) t

Janitor: list.h functions defined but not used

2009-04-19 Thread Glenn L. McGrath
Hi all, im new to the list, im interested in grinding away at some of the warnings wine generates... make depend was complaining about some static inline functions that it thinks arent used, this patch uses __attribute__ ((used)) to disable the warning. Glenn diff --git a/include/wine/list.h b