Re: Interesting find with cppcheck..

2009-08-05 Thread James McKenzie
Scott Ritchie wrote: > chris ahrendt wrote: > >> Austin English wrote: >> >>> On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang wrote: >>> >>> > If the group wants I can run this daily when I run wine test as well.. > and post it here just let me know > >

Re: Interesting find with cppcheck..

2009-08-05 Thread chris ahrendt
Scott Ritchie wrote: > chris ahrendt wrote: > >> Austin English wrote: >> >>> On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang wrote: >>> >>> > If the group wants I can run this daily when I run wine test as well.. > and post it here just let me know > >

Re: Interesting find with cppcheck..

2009-08-05 Thread Scott Ritchie
chris ahrendt wrote: > Austin English wrote: >> On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang wrote: >> If the group wants I can run this daily when I run wine test as well.. and post it here just let me know >>> Probably not. Most of the remaining leaks are in the tests

Re: Interesting find with cppcheck..

2009-08-05 Thread Alexandre Julliard
Francois Gouget writes: > On Tue, 4 Aug 2009, Juan Lang wrote: > >> > Still wouldn't hurt to fix them. >> >> Well, Alexandre routinely rejects such "fixes." > > It may be worth reconsidering. > > Just like if you have hundreds of compilation warnings the useful ones > get lost in the sea, if su

Re: Interesting find with cppcheck..

2009-08-04 Thread Ben Klein
2009/8/5 Francois Gouget : > On Tue, 4 Aug 2009, Juan Lang wrote: > >> > Still wouldn't hurt to fix them. >> >> Well, Alexandre routinely rejects such "fixes." > > It may be worth reconsidering. > > Just like if you have hundreds of compilation warnings the useful ones > get lost in the sea, if suc

Re: Interesting find with cppcheck..

2009-08-04 Thread Francois Gouget
On Tue, 4 Aug 2009, Juan Lang wrote: > > Still wouldn't hurt to fix them. > > Well, Alexandre routinely rejects such "fixes." It may be worth reconsidering. Just like if you have hundreds of compilation warnings the useful ones get lost in the sea, if such these tools report too many valid lea

Re: Interesting find with cppcheck..

2009-08-04 Thread chris ahrendt
Austin English wrote: > On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang wrote: > >>> If the group wants I can run this daily when I run wine test as well.. >>> and post it here just let me know >>> >> Probably not. Most of the remaining leaks are in the tests or the >> tools. Since thes

Re: Interesting find with cppcheck..

2009-08-04 Thread Juan Lang
> Still wouldn't hurt to fix them. Well, Alexandre routinely rejects such "fixes." --Juan

Re: Interesting find with cppcheck..

2009-08-04 Thread Austin English
On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang wrote: >> If the group wants I can run this daily when I run wine test as well.. >> and post it here  just let me know > > Probably not.  Most of the remaining leaks are in the tests or the > tools.  Since these are short-lived programs, the leaks will

Re: Interesting find with cppcheck..

2009-08-04 Thread Juan Lang
> If the group wants I can run this daily when I run wine test as well.. > and post it here  just let me know Probably not. Most of the remaining leaks are in the tests or the tools. Since these are short-lived programs, the leaks will get plugged as soon as the programs end anyway. The onl

Re: Interesting find with cppcheck..

2009-08-04 Thread chris ahrendt
Juan Lang wrote: > Hi Chris, > > >> [../wine-git/dlls/crypt32/rootstore.c:346]: (error) Resource leak: dir >> > > I just sent a patch to fix this. Thanks! > --Juan > > > If the group wants I can run this daily when I run wine test as well.. and post it here just let me know Chri

Re: Interesting find with cppcheck..

2009-08-04 Thread Juan Lang
Hi Chris, > [../wine-git/dlls/crypt32/rootstore.c:346]: (error) Resource leak: dir I just sent a patch to fix this. Thanks! --Juan

Re: Interesting find with cppcheck..

2009-08-04 Thread Austin English
On Tue, Aug 4, 2009 at 1:00 PM, chris ahrendt wrote: > > I was working on something else and using cppcheck to make sure I was > not having a memory leak and so forth and decided to try it on wine > here is what is the results of the wine git tree : > > [../wine-git/dlls/crypt32/rootstore.c:346]: (

Interesting find with cppcheck..

2009-08-04 Thread chris ahrendt
I was working on something else and using cppcheck to make sure I was not having a memory leak and so forth and decided to try it on wine here is what is the results of the wine git tree : [../wine-git/dlls/crypt32/rootstore.c:346]: (error) Resource leak: dir [../wine-git/dlls/msvcrt/tests/file.