Re: Integer overflow problem in string::compare()

2012-07-02 Thread Dan Kegel
On Mon, Jul 2, 2012 at 2:51 AM, Piotr Caban wrote: > This patch looks correct. It's also good to fix other functions with similar > bug. Great, I'll have a bigger patchset for review in a few days. Thanks, Dan

Re: Integer overflow problem in string::compare()

2012-07-02 Thread Piotr Caban
Hi, On 07/02/12 04:13, Dan Kegel wrote: could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ? If you like it, I'll submit it to wine-patches. It passes winetestbot and gets pulsen and stepmania past the splash screen abort. This patch looks correct. It's also good to fix

Integer overflow problem in string::compare()

2012-07-01 Thread Dan Kegel
Hi Piotr, could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ? If you like it, I'll submit it to wine-patches. It passes winetestbot and gets pulsen and stepmania past the splash screen abort. Why are there no tests for msvcp60? If you think it's appropriate, I can add the