On 30 January 2010 16:44, Geoffrey Hausheer
wrote:
> On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote:
>>
>> Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer:
>> > Is there anything I can do to move this patch forward? I've fixed all
>> > the
>> > issues that have been
On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote:
> Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer:
> > Is there anything I can do to move this patch forward? I've fixed all
> the
> > issues that have been raised so far. I have no dea what it is waiting
> on,
> > and
Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer:
> Is there anything I can do to move this patch forward? I've fixed all the
> issues that have been raised so far. I have no dea what it is waiting on,
> and if there is anything I can do to get it committed or if it is just a
> questi
Is there anything I can do to move this patch forward? I've fixed all the
issues that have been raised so far. I have no dea what it is waiting on,
and if there is anything I can do to get it committed or if it is just a
question of being patient. As I said previously I'd happily write a test
fo
On Wed, Jan 13, 2010 at 10:38 PM, Piotr Caban wrote:
> Hi,
>
> There're still some things that needs to be changed.
Thank you for the continued feedback.
>
> In pixels_to_dialog_units:
> + *basex = ((float)size.cx/26+1)/2;
>
> + *x_pixels = MulDiv(*x_pixels, 4, *basex);
> I proposed doin
Hi,
There're still some things that needs to be changed.
In prop_sheet_proc:
+case WM_DESTROY:
+ {
+OLEPropertyFrame *opf = (OLEPropertyFrame
*)GetWindowLongPtrW(hwnd, DWLP_USER);
+if(opf) {
+IPropertyPage_Show(opf->propPage, SW_HIDE);
+IPropertyPa
Hi,
In prop_sheet_proc you wrote:
case PSN_APPLY:
FIXME("(%p, %s, %s)\n", hwnd, "WM_NOTIFY", "PSN_APPLY");
IPropertyPage_Apply(opf->propPage);
return TRUE;
If I understand it correctly applying changes is fully implemented. Why
there's a FIXME? Probably you wanted to us
