Re: cleaned version of Implement IStream interface for msxml3 domdoc

2008-01-12 Thread Alistair Leslie-Hughes
"Josef Reidinger" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] >I cleaned previous version and add it to one patch which have no tabs > and indent is same as code around. Also change my mail, old have some > problems with sending mail to this list. > > copy from previous Since the

Re: Implement IStream interface for msxml3 domdoc

2008-01-12 Thread Alistair Leslie-Hughes
IStream *iface, void const *pv, ULONG cb, ULONG *pcbRead) { + TRACE("\n"); domdoc *This = impl_from_IStream(iface); - return IStream_Write(This->stream,pv,cb,pcbRead); +if (!This->chunkParser){ + TRACE("1"); Remove unneeded TRACE statements. Best Regards Alistair Leslie-Hughes

Re: Implement IStream interface for msxml3 domdoc

2008-01-12 Thread Dmitry Timoshkov
"Josef Reidinger" <[EMAIL PROTECTED]> wrote: > changelog: > * implement IStream write for msxml domdoc What are the tab settings in your editor? All white space in your patches looks completely broken. Set tab size to 8 spaces, and try to avoid tabs at all. > + if (!This->Stream){ > + > + }

Re: Implement IStream interface for msxml3 domdoc

2008-01-12 Thread L. Rahyen
On Saturday January 12 2008 11:31:38 Josef Reidinger wrote: > This patch fix bug #4811. It implements IStream interface for dom > document in msxml. Really implemented is needed part of write function, > other function is not implemented. Part is also not implemented by > windows (readed only at ms