Re: Implement DceErrorInqText

2004-12-22 Thread Bill Medland
On December 22, 2004 08:25 am, Alexandre Julliard wrote: > Bill Medland <[EMAIL PROTECTED]> writes: > > Oh. I thought we wanted to do the same as Windows does!!! > > > > Don't ask me why but for some error codes (as detailed in the patch), > > even though FormatMessage can return a perfectly reaso

Re: Implement DceErrorInqText

2004-12-22 Thread Alexandre Julliard
Bill Medland <[EMAIL PROTECTED]> writes: > Oh. I thought we wanted to do the same as Windows does!!! > > Don't ask me why but for some error codes (as detailed in the patch), even > though FormatMessage can return a perfectly reasonable string, > DceErrorInqText doesn't return it. E.g. 7050,

Re: Implement DceErrorInqText

2004-12-22 Thread Bill Medland
On December 22, 2004 06:47 am, Alexandre Julliard wrote: > Bill Medland <[EMAIL PROTECTED]> writes: > > My comments are probably not clear enough. That function isn't asking if > > the error code is a valid error code (which is relevant to > > FormatMessage). Actually !acceptable_rpc_code is the l

Re: Implement DceErrorInqText

2004-12-22 Thread Alexandre Julliard
Bill Medland <[EMAIL PROTECTED]> writes: > My comments are probably not clear enough. That function isn't asking if the > error code is a valid error code (which is relevant to FormatMessage). > Actually !acceptable_rpc_code is the list of error codes for which > FormatMessage will return a v

Re: Implement DceErrorInqText

2004-12-22 Thread Bill Medland
On December 21, 2004 10:50 pm, Dmitry Timoshkov wrote: Thanks for the feedback > "Bill Medland" <[EMAIL PROTECTED]> wrote: > > +RPC_STATUS RPC_ENTRY DceErrorInqTextW (unsigned long e, unsigned short > > *b) +{ > > +DWORD count; > > +if (acceptable_rpc_code (e)) > > It would be much more n

Re: Implement DceErrorInqText

2004-12-21 Thread Dmitry Timoshkov
"Bill Medland" <[EMAIL PROTECTED]> wrote: > +RPC_STATUS RPC_ENTRY DceErrorInqTextW (unsigned long e, unsigned short *b) > +{ > +DWORD count; > +if (acceptable_rpc_code (e)) It would be much more natural to make FormatMessageW to decide whether a passed error code is valid or not, i.e. if