Re: Implement DVD_ReadStructure

2006-02-09 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > So I guess headers from 'inc/ddk' would end up in 'include/ddk/ddk' in > Wine. Not that it's a problem. However, how do we decide whether a > header should go into Wine's 'include/ddk'? Is it based whether > Microsoft ships it with the PSDK or the DDK?

Re: Implement DVD_ReadStructure

2006-02-09 Thread Francois Gouget
On Thu, 9 Feb 2006, Alexandre Julliard wrote: Francois Gouget <[EMAIL PROTECTED]> writes: Actually both the latest PSDK and the DDK put ntddcdrm.h, ntddscsi.h and ntddstor.h straight in 'include' and not in 'include/ddk'. So this patch is probably correct. There's no include/ddk on Windows,

Re: Implement DVD_ReadStructure

2006-02-09 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Actually both the latest PSDK and the DDK put ntddcdrm.h, ntddscsi.h > and ntddstor.h straight in 'include' and not in 'include/ddk'. So this > patch is probably correct. There's no include/ddk on Windows, that's a Wine (and win32api) convention to se

Re: Implement DVD_ReadStructure

2006-02-09 Thread Francois Gouget
On Wed, 8 Feb 2006, Detlef Riekenberg wrote: Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: ChangeLog: Implement DVD_ReadStructure --- /dev/null 2006-02-03 18:20:42.451563144 +1100 +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.0 +1100 Please use

Re: Implement DVD_ReadStructure

2006-02-08 Thread Mike McCormack
Troy Rollo wrote: Regardless, I'm not revisiting patches anymore. If they get in, fine, but if not I'll just keep them on my branch - I work on more than one OSS project and I'm not sacrificing time on others to jump through hoops for Wine. It will probably save you time in the long run to k

Re: Implement DVD_ReadStructure

2006-02-08 Thread Dmitry Timoshkov
On Thu, 2006-02-09 at 08:48 +1100, Troy Rollo wrote: > > Why to bother sending patches at all then if you are not planning > > to improve them into an acceptable state? > > You seem to be under the mistaken impression that I place even the slightest > value on what you, Dmitry, consider to be an

Re: Implement DVD_ReadStructure

2006-02-08 Thread Troy Rollo
On Thursday 09 February 2006 08:38, Dmitry Timoshkov wrote: > Why to bother sending patches at all then if you are not planning > to improve them into an acceptable state? You seem to be under the mistaken impression that I place even the slightest value on what you, Dmitry, consider to be an ac

Re: Implement DVD_ReadStructure

2006-02-08 Thread Dmitry Timoshkov
On Thu, 2006-02-09 at 08:23 +1100, Troy Rollo wrote: > Regardless, I'm not revisiting patches anymore. If they get in, fine, but if > not I'll just keep them on my branch - I work on more than one OSS project > and I'm not sacrificing time on others to jump through hoops for Wine. Why to bothe

Re: Implement DVD_ReadStructure

2006-02-08 Thread Troy Rollo
On Thursday 09 February 2006 00:28, Detlef Riekenberg wrote: > Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: > > ChangeLog: > > Implement DVD_ReadStructure > > > > --- /dev/null 2006-02-03 18:20:42.451563144 +1100 > > +++ wine-git/in

Re: Implement DVD_ReadStructure

2006-02-08 Thread James Courtier-Dutton
Detlef Riekenberg wrote: Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: ChangeLog: Implement DVD_ReadStructure --- /dev/null 2006-02-03 18:20:42.451563144 +1100 +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.0 +1100 Please use "in

Re: Implement DVD_ReadStructure

2006-02-08 Thread James Courtier-Dutton
Detlef Riekenberg wrote: Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: ChangeLog: Implement DVD_ReadStructure --- /dev/null 2006-02-03 18:20:42.451563144 +1100 +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.0 +1100 Please use "in

Re: Implement DVD_ReadStructure

2006-02-08 Thread Detlef Riekenberg
Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: > ChangeLog: > Implement DVD_ReadStructure > --- /dev/null 2006-02-03 18:20:42.451563144 +1100 > +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.0 +1100 Please use "include/ddk/" -- By By ... ... Detlef