Re: Implement BiDi mirroring

2009-01-28 Thread Khaled Hosny
On Wed, Jan 28, 2009 at 11:22:04PM +0200, Khaled Hosny wrote: > On Wed, Jan 28, 2009 at 01:00:43PM -0800, Juan Lang wrote: > > Hi Khaled, > > > > +void doMirror(WCHAR* ch) > > > > This should be static. > > > > +else if(*ch == mirrored[k].first) > > +{ > > +*c

Re: Implement BiDi mirroring

2009-01-28 Thread Khaled Hosny
On Wed, Jan 28, 2009 at 01:00:43PM -0800, Juan Lang wrote: > Hi Khaled, > > +void doMirror(WCHAR* ch) > > This should be static. > > +else if(*ch == mirrored[k].first) > +{ > +*ch = mirrored[k].mirror; > +return; > +} > > The else

Re: Implement BiDi mirroring

2009-01-28 Thread Juan Lang
Hi Khaled, +void doMirror(WCHAR* ch) This should be static. +else if(*ch == mirrored[k].first) +{ +*ch = mirrored[k].mirror; +return; +} The else if block is indented one level too many. Thanks, --Juan