Re: ImmIsUIMessageA/W

2012-10-03 Thread André Hentschel
Am 03.10.2012 17:19, schrieb Aric Stewart: > Great! > > Looking at the application I have that was requiring this i have found that > by adding the "IME" window class it has actually corrected its behavior. > > You are correct to have removed that redirection and I will not submit a > patch to

Re: ImmIsUIMessageA/W

2012-10-03 Thread Aric Stewart
Great! Looking at the application I have that was requiring this i have found that by adding the "IME" window class it has actually corrected its behavior. You are correct to have removed that redirection and I will not submit a patch to re-add it as it is incorrect. thanks for the help! -aric

Re: ImmIsUIMessageA/W

2012-10-02 Thread André Hentschel
Am 02.10.2012 21:23, schrieb Aric Stewart: > I have a proposed patch that I have tested with World of Tanks and it does > not cause http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on > either mac or Linux. > > Would you be able to test it and confirm that I am not reintroduction

Re: ImmIsUIMessageA/W

2012-10-02 Thread Aric Stewart
I have a proposed patch that I have tested with World of Tanks and it does not cause http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on either mac or Linux. Would you be able to test it and confirm that I am not reintroduction the issues? thanks! -aric On 9/25/12 2:54 PM, Henr

Re: ImmIsUIMessageA/W

2012-09-25 Thread André Hentschel
Am 25.09.2012 21:54, schrieb Henri Verbeet: > On 25 September 2012 21:12, André Hentschel wrote: >> I don't remember the app, be free to patch it in again, at best with tests. >> > Wasn't that for World of Tanks? > Oh, true. thx. It's all about http://bugs.winehq.org/show_bug.cgi?id=27554 d08fa6

Re: ImmIsUIMessageA/W

2012-09-25 Thread Henri Verbeet
On 25 September 2012 21:12, André Hentschel wrote: > I don't remember the app, be free to patch it in again, at best with tests. > Wasn't that for World of Tanks?

Re: ImmIsUIMessageA/W

2012-09-25 Thread André Hentschel
Am 25.09.2012 14:48, schrieb Aric Stewart: >> >>> also you eliminate the part where if the incoming hWndIME is NULL we send >>> the message to the thread's default IME window. >> >> my changes made an app happy IIRC, further i think i was skeptical about >> IMM_GetThreadData()->hwndDefault becaus

Re: ImmIsUIMessageA/W

2012-09-25 Thread Aric Stewart
>> because of: >> >> commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 >> Author: André Hentschel >> Date: Sat Jun 25 16:13:41 2011 +0200 >> >> imm32: Test and fix ImmIsUIMessageA/W. >> >> in that patch I see that you eliminate the part where w

Re: ImmIsUIMessageA/W

2012-09-24 Thread André Hentschel
29aa5 > Author: André Hentschel > Date: Sat Jun 25 16:13:41 2011 +0200 > > imm32: Test and fix ImmIsUIMessageA/W. > > in that patch I see that you eliminate the part where we check if there is a > default IME window and if not then create one.

ImmIsUIMessageA/W

2012-09-21 Thread Aric Stewart
and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL

copy/paste bug in imm32: Test and fix ImmIsUIMessageA/W?

2011-07-01 Thread wylda
Hi, i guess you know my programming skill, so be nice to me if total nonsence: if ( ... || ... +(msg == WM_IME_SELECT) || +(msg == WM_IME_SELECT) || ... seem to redundant. It happens it two places. Regards, W.

Re: [2/2] imm32: Factor out the message checks from ImmIsUIMessageA/W and fix them

2011-06-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11778 Your paranoid android

Re: [2/2] imm32: Factor out the message checks from ImmIsUIMessageA/W and fix them

2011-06-16 Thread André Hentschel
Am 16.06.2011 23:22, schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-18 Thread Aric Stewart
Ahh ok, thanks. Will do. -aric Alexandre Julliard wrote: > Aric Stewart writes: > >> Since I value your input in imm32 and i do a lot of work there. If you >> would like to send me that high level overview then I can see if it >> works into wine. That way you can continue to contribute and w

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-18 Thread Alexandre Julliard
Aric Stewart writes: > Since I value your input in imm32 and i do a lot of work there. If you > would like to send me that high level overview then I can see if it > works into wine. That way you can continue to contribute and we do not > compromise the source code. No, please don't do that.

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-17 Thread Aric Stewart
an e-mail describing what they do. -aric James Hawkins wrote: > On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon wrote: >> By an analysis of the ImmIsUIMessageA/W disassemble code, >> 1. checked msg : >> WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, >>

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-17 Thread James Hawkins
On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon wrote: > By an analysis of the ImmIsUIMessageA/W disassemble code, > 1. checked msg : > WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, > WM_IME_SETCONTEXT, WM_IME_NOTIFY, > WM_IME_COMPOSITIONFULL, WM_IME_SELECT. > 2