Re: Icons as cursors patch

2008-11-25 Thread Andrew Riedi
On Tue, Nov 25, 2008 at 4:04 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: >> Isn't this already covered in the cursoricon tests? > I don't think so. That test would be marked TODO_WINE in that case, so your > patch would cause a test failure(unexpected success). If that test wasn't > marked todo

RE: Icons as cursors patch

2008-11-25 Thread Stefan Dösinger
> Isn't this already covered in the cursoricon tests? I don't think so. That test would be marked TODO_WINE in that case, so your patch would cause a test failure(unexpected success). If that test wasn't marked todo the behavior your patch adds would be implemented already.

Re: Icons as cursors patch

2008-11-24 Thread Krzysztof Drewniak
Isn't this already covered in the cursoricon tests? Stefan Dösinger wrote: >> I know this isn't a coded test, bot The Sims 2 behave in this way. This >> > was > previously stated WAY back on this list. > Yes, but do you know if Sims 2 behaves that way on Windows? There could be > some other b

RE: Icons as cursors patch

2008-11-24 Thread Stefan Dösinger
> I know this isn't a coded test, bot The Sims 2 behave in this way. This was > previously stated WAY back on this list. Yes, but do you know if Sims 2 behaves that way on Windows? There could be some other bug triggering this behavior in Sims. That's where a test helps even in these cases: If yo

Re: Icons as cursors patch

2008-11-24 Thread Roderick Colenbrander
A real small test app if possible as a wine test is needed to demonstrate it is really correct. Sorry it can be a pain but it is to prevent issues in other apps which might be very hard to debug if an incorrect patch enters Wine. Roderick > I know this isn't a coded test, bot The Sims 2 behave

Re: Icons as cursors patch

2008-11-24 Thread Krzysztof Drewniak
I know this isn't a coded test, bot The Sims 2 behave in this way. This was previously stated WAY back on this list. Stefan Dösinger wrote: > Hi, > >> This is my first patch. It allows icons to be loaded as cursors because >> it defaults hotspots to x = 0 and y = 0 if the hotspot isn't found. >

RE: Icons as cursors patch

2008-11-24 Thread Stefan Dösinger
Hi, > This is my first patch. It allows icons to be loaded as cursors because > it defaults hotspots to x = 0 and y = 0 if the hotspot isn't found. > Pasting patch into body of message. This is against the latest git . I recommend to write a test case to show that Windows behaves in the same way.

Icons as cursors patch

2008-11-23 Thread Krzysztof Drewniak
This is my first patch. It allows icons to be loaded as cursors because it defaults hotspots to x = 0 and y = 0 if the hotspot isn't found. Pasting patch into body of message. This is against the latest git . -