Re: ID3DXBaseEffect::SetValue

2012-02-07 Thread luis.busqu...@ilidium.com
For the textures point, it is judt that the implemenyation is just the change of one pointer - Reply message - De: "Rico Schüller" Para: "Luis Carlos Busquets Pérez" CC: Asunto: ID3DXBaseEffect::SetValue Fecha: mar., feb. 7, 2012 10:03 Am 07.02.2012 06:02,

Re: ID3DXBaseEffect::SetValue

2012-02-07 Thread luis.busqu...@ilidium.com
D3DERR_INVALIDCALL and their implementation in SetValue is straight. - Reply message - De: "Rico Schüller" Para: "Luis Carlos Busquets Pérez" CC: Asunto: ID3DXBaseEffect::SetValue Fecha: mar., feb. 7, 2012 10:03 Am 07.02.2012 06:02, schrieb Luis Carlos Busquet

Re: ID3DXBaseEffect::SetValue

2012-02-07 Thread Rico Schüller
Am 07.02.2012 06:02, schrieb Luis Carlos Busquets Pérez: 1. If the functions returns E_FAIL for a sample then test_effect.c:1917: Test failed: Got result 80004005, expected 0 (D3D_OK) I'll have a look at those. 2. For D3DXPT_VERTEXSHADER and D3DXPT_PIXELSHADER replying with E_FAIL avoids

Re: ID3DXBaseEffect::SetValue

2012-02-06 Thread Rico Schüller
ffect interface (see http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3dx9_36/tests/effect.c#l161 ). Beside that, please have a look at http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3dx9_36/tests/effect.c#l1585 , which calls ID3DXBaseEffect::SetValue through ID3DXEffect. There it do

ID3DXBaseEffect::SetValue

2012-02-06 Thread Luis Carlos Busquets Pérez
The functin returns D3DERR_INVALIDCALL whenever it is tried on a parameter with elements. A check should be included. Luis

Re: [PATCH 4/4] d3dx9: Implement ID3DXBaseEffect::SetValue().

2011-12-13 Thread Matteo Bruni
2011/12/13 Rico Schüller : > --- >  dlls/d3dx9_36/effect.c |   42 -- >  1 files changed, 40 insertions(+), 2 deletions(-) > > +TRACE("Copy %u bytes\n", param->bytes); > +memcpy(param->data, data, bytes); That trace is not corr