Re: Help with 6120d7cc145, causing bugs

2010-08-28 Thread Jeff Cook
Wylda reported success with the attached patch on bug 23902. Does it seem OK to everyone else? In this case, the extra channel needed for capture is not added when a micelem is found, because micelem should only be found when there is no other suitable playback or capture controls (i.e. "Mic" eleme

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread Henri Verbeet
On 27 August 2010 15:14, wrote: > All apps are working perfectly! Could i kindly ask you for sending > to patches today? It looks like i will have spare time for testing, > so it will help me to not to mess with revering. > It's probably not quite correct. In particular, before 6120d7cc145 it's l

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread sudemon
On 27.08.2010 18:47, Henri Verbeet wrote: 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 actually does, does the attached patch make any difference for you? Thanks, patch solved the problem.

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread wylda
> Actually, looking a bit at what > 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 actually > does, does the attached patch make any difference for you? Yes! :-D For crashing tested on: Warcarft 3, 3DMark 2001 SE, Harbinger For HEAP corruption tested on: Demoscene debris All apps are working perfect

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread Henri Verbeet
On 27 August 2010 14:33, Henri Verbeet wrote: > clearly outside that range. At first sight I'd say there's an error in > the calculation for "mixdev[mixnum].chans" somewhere, that's what > ultimately determines the size of the block that's allocated above, > and should correspond to the number of

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread Henri Verbeet
On 27 August 2010 14:04, wrote: > > Also from log previously attached, following string is written to > address out of this word, isn't? Look like some return address than > HEAP, right? > > 0009:Call KERNEL32.MultiByteToWideChar(fdf2,,0021cac8 > "HDA NVidia",,7dfc9ee4,002

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread wylda
Also from log previously attached, following string is written to address out of this word, isn't? Look like some return address than HEAP, right? 0009:Call KERNEL32.MultiByteToWideChar(fdf2,,0021cac8 "HDA NVidia",,7dfc9ee4,0020) ret=7dfb2ae4 0009:Ret KERNEL32.MultiByteTo

Re: Help with 6120d7cc145, causing bugs

2010-08-27 Thread wylda
> > There have been a few bug reports... > http://bugs.winehq.org/show_bug.cgi?id=23902 and > http://bugs.winehq.org/show_bug.cgi?id=24131 . > > It seems that in some relatively rare sound > setups, an inappropriate sound element gets fed in to > filllines_no_master which leads to a crash on aud

Help with 6120d7cc145, causing bugs

2010-08-24 Thread Jeff Cook
Just wondering if I could get a bit more review on commit 6120d7cc145 which was committed in early August. Here's a link: http://source.winehq.org/git/wine.git/?a=commit;h=6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 There have been a few bug reports filed against it recently, see http://bugs.wine