Re: Help needed: BSTR cache testing

2009-10-09 Thread Alexandre Julliard
Michael Stefaniuc writes: > Roderick Colenbrander wrote: >> Blackbox reverse engineering is feeding test input to a function and >> looking at the output. A trace of calls made by the native MS dll >> while looking under Wine isn't blackbox. It is considered about the >> same as looking at disass

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 02:15 PM, Paul Vriens wrote: On 10/09/2009 02:07 PM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: Hi Markus, Isn't there a way that you can change the tests to show this number (in some kind of loop by creating a larger second string on t

Re: Help needed: BSTR cache testing

2009-10-09 Thread Michael Stefaniuc
Roderick Colenbrander wrote: > On Fri, Oct 9, 2009 at 2:25 PM, Markus Stockhausen > wrote: >> Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: >> >>> If that sz99 (or now sz128) came from "looking at internal behaviour", >>> I'm not sure if that would raise some eyebrows. >>> >> As I s

Re: Help needed: BSTR cache testing

2009-10-09 Thread Roderick Colenbrander
On Fri, Oct 9, 2009 at 2:25 PM, Markus Stockhausen wrote: > Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > >> If that sz99 (or now sz128) came from "looking at internal behaviour", >> I'm not sure if that would raise some eyebrows. >> > > As I said "looking at internal behaviour" a

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > If that sz99 (or now sz128) came from "looking at internal behaviour", > I'm not sure if that would raise some eyebrows. > ... and I simply allocate a "very large" string to ensure that no reuse of the just freed small memory portion

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 14:15 +0200 schrieb Paul Vriens: > If that sz99 (or now sz128) came from "looking at internal behaviour", > I'm not sure if that would raise some eyebrows. > As I said "looking at internal behaviour" are debugging messages in the IMalloc routines of ifs.c. Simply som

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 02:07 PM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: Hi Markus, Isn't there a way that you can change the tests to show this number (in some kind of loop by creating a larger second string on the go)? It simply boils down to this one

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 13:43 +0200 schrieb Paul Vriens: > Hi Markus, > > Isn't there a way that you can change the tests to show this number (in > some kind of loop by creating a larger second string on the go)? > It simply boils down to this one and only testcase. A SysFreeString will alw

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 10:12 AM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 01:05 -0700 schrieb Dan Kegel: Also, how did you decide on the size of sz99? I do not want to explain this in detail, as it is the result of looking at internal behaviour (something that is not liked very much as I u

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 01:05 -0700 schrieb Dan Kegel: > Also, how did you decide on the size of sz99? I do not want to explain this in detail, as it is the result of looking at internal behaviour (something that is not liked very much as I understand now). But to make a long story short: Thi

Re: Help needed: BSTR cache testing

2009-10-09 Thread Dan Kegel
Markus Stockhausen wrote: >> Please extend the test cases in >> dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs >> properly, and make sure that test passes on Windows >> and is marked todo_wine. > > Already sent. Take a look here: > http://www.winehq.org/pipermail/wine-devel/2009-Octo

Re: Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 09:56 +0200 schrieb Paul Vriens: > On 10/09/2009 09:38 AM, Markus Stockhausen wrote: > > Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: > >> Hi Markus, > >> Wine development is driven by test cases checked in to the > >> Wine source tree. Please extend the t

Re: Help needed: BSTR cache testing

2009-10-09 Thread Paul Vriens
On 10/09/2009 09:38 AM, Markus Stockhausen wrote: Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: Hi Markus, Wine development is driven by test cases checked in to the Wine source tree. Please extend the test cases in dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs prope

Help needed: BSTR cache testing

2009-10-09 Thread Markus Stockhausen
Am Freitag, den 09.10.2009, 00:27 -0700 schrieb Dan Kegel: > Hi Markus, > Wine development is driven by test cases checked in to the > Wine source tree. Please extend the test cases in > dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs > properly, and make sure that test passes on Wind