Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
On Mon, 2005-01-10 at 11:31 -0600, Robert Shearman wrote: > You don't need to add these unnecessary brackets. They add nothing to > the readability of the code. I normally wouldn't but the code style in that section is to avoid stuff like this: if (foo) bar else { baz } which I

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Robert Shearman
Mike Hearn wrote: ... static NTSTATUS load_dll( LPCWSTR load_path, LPCWSTR libname, DWORD flags, WINE_MODREF** pwm ); static FARPROC find_named_export( HMODULE module, const IMAGE_EXPORT_DIRECTORY *exports, @@ -893,9 +894,17 @@ static NTSTATUS process_attach( WINE_MOD WINE_MODREF *prev = cu

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
On Mon, 2005-01-10 at 17:19 +0100, Alexandre Julliard wrote: > It needs to be at most a warning, attach failures can legitimately > happen. OK, here's a better patch fixed w.r.t what we talked about on IRC. Give a more informative error when a DLL fails to initialize during star

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > This patch was missed, does it no longer apply? It needs to be at most a warning, attach failures can legitimately happen. > Also is it OK to just put the changelog as the first line of the email > like that? Sure. -- Alexandre Julliard [EMAIL PROTECTE

Re: Give a more informative error when a DLL fails to initialize

2005-01-10 Thread Mike Hearn
Hi Alexandre, This patch was missed, does it no longer apply? Also is it OK to just put the changelog as the first line of the email like that? thanks -mike On Wed, 22 Dec 2004 18:19:47 +, Mike Hearn wrote: > Give a more informative error when a DLL fails to initialize > --- dlls