Re: kernel32/tests: test that GetModuleFileName returns an absolute path

2011-12-25 Thread Thomas Faber
On 2011-12-25 17:12, Dmitry Timoshkov wrote: > Thomas Faber wrote: > >> diff --git a/dlls/kernel32/tests/Makefile.in >> b/dlls/kernel32/tests/Makefile.in >> index dce27db..2ce3ec6 100644 >> --- a/dlls/kernel32/tests/Makefile.in >> +++ b/dlls/kernel32/tests/Makefile.in >> @@ -1,5 +1,5 @@ >> TEST

Re: kernel32/tests: test that GetModuleFileName returns an absolute path

2011-12-25 Thread Dmitry Timoshkov
Thomas Faber wrote: > diff --git a/dlls/kernel32/tests/Makefile.in b/dlls/kernel32/tests/Makefile.in > index dce27db..2ce3ec6 100644 > --- a/dlls/kernel32/tests/Makefile.in > +++ b/dlls/kernel32/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = kernel32.dll > -IMPORTS = user32 advapi32 > +IMPO

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.

2011-09-29 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14640 Your paranoid android

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.

2011-09-29 Thread Francois Gouget
On Fri, 30 Sep 2011, Francois Gouget wrote: > This is necessary because LastError may already be set to > ERROR_INSUFFICIENT_BUFFER which would mislead the caller. And of course the older versions of Windows (up to XP SP3!) don't reset lasterror so the test bit of the patch cannot go in. I'd st

Re: GetModuleFileName

2004-04-18 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > What is the right thing? strlcpy? Usually lstrcpynA/W. -- Alexandre Julliard [EMAIL PROTECTED]

Re: GetModuleFileName

2004-04-18 Thread Juan Lang
Alexandre wrote: > I doubt it fills the buffer with nulls if it is too > large though, so strncpy is probably not the right > thing to use here (in fact strncpy is almost always > the wrong function to use, we should probably have > a janitorial task to fix this everywhere). What is the right thin

Re: GetModuleFileName

2004-04-18 Thread Alexandre Julliard
Eric Pouech <[EMAIL PROTECTED]> writes: > Interestingly enough, GetModuleFileName[AW] doesn't '\0'-terminate the > buffer if it is too small > Our current implementation was terminating the buffer. > This patch fixes this, and adds a test case for that behavio

Re: GetModuleFileName mysteries

2003-12-31 Thread Alexandre Julliard
ould be recorded and later served on requests like > GetModuleFileName and others. It's not that easy, because system dlls have to be loaded from the system directory, so you need GetModuleFileName to return that. It's only for dlls loaded with a explicit path that you can try to return

Re: GetModuleFileName mysteries

2003-12-31 Thread Tom
Boaz Harrosh wrote: And while we are at it. What is the wine policy about Built-in DLLs versions. I have encountered problems where setups where complaining about versions been "0.0.0.0" and also some other not high enough versions. Should we make a quick study about Windows versions and serve

Re: GetModuleFileName mysteries

2003-12-31 Thread Boaz Harrosh
. If any one is working on it, built in search should support both explicit Path loading, and executable directory. Same as native, Just that the PATH and system-folder changes to WINEDLLPATH. Once the built-in is found it's PATH should be recorded and later served on requests like GetModul

Re: GetModuleFileName mysteries

2003-12-30 Thread Alexandre Julliard
"Ralf Juengling" <[EMAIL PROTECTED]> writes: > But what is the reason for having GetModuleFileName return the system > dir for "builtin DLLs"? Because we don't know the real path, and even if we did there is no guarantee that it is accessible from a Windo

Re: GetModuleFileName mysteries

2003-12-24 Thread Ralf Juengling
- Original Message - From: "Eric Pouech" <[EMAIL PROTECTED]> To: "Ralf Juengling" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Tuesday, December 23, 2003 11:05 PM Subject: Re: GetModuleFileName mysteries > basically, because for buil

Re: GetModuleFileName mysteries

2003-12-24 Thread Eric Pouech
Well yes ... and ... I don't get it I ask for foo.dll.so (GetModuleFileName) please give it to me. What is this problems here? I would like to look into my self. Any problems with that? Usually I Just need to know the full path of the Installation. Built in or not give me the file strai

Re: GetModuleFileName mysteries

2003-12-24 Thread Boaz Harrosh
Eric Pouech wrote: basically, because for builtin DLLs, the real file (foo.dll) doesn't exist (only foo.dll.so does). So, we decided to return all builtin DLLs in the system dir. Note that this only applies to builtin DLLs, native DLLs will return the correct path in GetModuleFil

Re: GetModuleFileName mysteries

2003-12-24 Thread Eric Pouech
Ralf Juengling wrote: I have some Windows code that uses GetModuleFileName in order to read some additional files at runtime that are expected at certain place relative to the executable. In Wine, GetModuleFileName doesn't work as intended, and I have trouble to track down the problem. I h

GetModuleFileName mysteries

2003-12-22 Thread Ralf Juengling
I have some Windows code that uses GetModuleFileName in order to read some additional files at runtime that are expected at certain place relative to the executable. In Wine, GetModuleFileName doesn't work as intended, and I have trouble to track down the problem. I had to use winemaker&#x